Move children isolator union insertion before distribution - #565
Merged
gabotechs merged 1 commit intoJul 27, 2026
Merged
Conversation
alexanderbianchi
force-pushed
the
codex/children-isolator-union-prepass
branch
from
July 26, 2026 19:11
e343ef8 to
22f631e
Compare
alexanderbianchi
marked this pull request as ready for review
July 26, 2026 19:15
alexanderbianchi
force-pushed
the
codex/children-isolator-union-prepass
branch
from
July 26, 2026 19:18
22f631e to
44fe33e
Compare
gabotechs
approved these changes
Jul 27, 2026
gabotechs
left a comment
gabotechs
left a comment
Collaborator
There was a problem hiding this comment.
Nice! I was expecting this to be a bit more complicated, but it turns out it was simpler. 👍 good work.
Comment on lines
+132
to
+133
| /// Creates a single-node union placeholder with every child assigned to the default task. | ||
| pub(crate) fn new( |
Collaborator
There was a problem hiding this comment.
I'd probably call this "new_single_task" or something more descriptive.
alexanderbianchi
force-pushed
the
codex/children-isolator-union-prepass
branch
from
July 27, 2026 14:48
44fe33e to
4f63440
Compare
gabotechs
approved these changes
Jul 27, 2026
gabotechs
left a comment
gabotechs
left a comment
Collaborator
There was a problem hiding this comment.
👍 Looks good, thanks @alexanderbianchi!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
UnionExecwithChildrenIsolatorUnionExecbefore annotation and network-boundary distribution.ChildrenIsolatorUnionExecfor child task-count propagation without constructing the node there.distribute_plan, where final task counts are available.Why
Fixes #539. This keeps union-isolator insertion out of the network-boundary distribution recursion while preserving the existing per-task assignment behavior.
Validation
cargo fmtcargo test --libcargo test --lib insert_children_isolator_union