Skip to content

feat: add support for ephemeral disk-backed storage to preprocessing jobs - #167

Draft
rohitkumarbhagat wants to merge 1 commit into
mainfrom
cloudrun-ephemeral
Draft

feat: add support for ephemeral disk-backed storage to preprocessing jobs#167
rohitkumarbhagat wants to merge 1 commit into
mainfrom
cloudrun-ephemeral

Conversation

@rohitkumarbhagat

Copy link
Copy Markdown
  • update Google provider to v7.30.0

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for optional disk-backed temporary storage in the Cloud Run preprocessing job to handle large datasets, configuring the necessary Terraform variables, volume mounts, and environment variables. Feedback on the changes points out that specifying medium = "DISK" inside the empty_dir block is invalid in the Google Cloud Run v2 API and should be omitted to default to disk-backed storage.

Comment thread infra/dcp/modules/ingestion/preprocessing_job/main.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant