Skip to content

Updated manifest.json with cron schedule - #2113

Open
gautamabrol wants to merge 2 commits into
datacommonsorg:masterfrom
gautamabrol:nydiabetes
Open

Updated manifest.json with cron schedule#2113
gautamabrol wants to merge 2 commits into
datacommonsorg:masterfrom
gautamabrol:nydiabetes

Conversation

@gautamabrol

@gautamabrol gautamabrol commented Jul 27, 2026

Copy link
Copy Markdown

Import name = NewYorkUniversity_Diabetes
PR checklist = Doc

Overview

Updated manifest.json with cron schedule

Key Changes

  • Missing cron schedule in the manifest.

@google-cla

google-cla Bot commented Jul 27, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the manifest.json file for the New York diabetes statistical variable import by adding cron_schedule, resource_limits, and config_override configurations. The review feedback suggests standardizing the indentation of these newly added fields to maintain consistency with the rest of the file's 4-space hierarchy.

Comment on lines +35 to +45
"cron_schedule": "0 0 1 * *",
"resource_limits": {"cpu": 4, "memory": 8, "disk":100},
"config_override": {
"invoke_import_validation": true,
"invoke_import_tool": true,
"invoke_differ_tool": true,
"skip_input_upload": false,
"skip_gcs_upload": false,
"cleanup_gcs_volume_mount": false
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation of the newly added fields (cron_schedule, resource_limits, and config_override) is inconsistent with the rest of the file. Standardizing the indentation to match the surrounding 4-space hierarchy improves readability and maintainability.

            "cron_schedule": "0 0 1 * *",
            "resource_limits": {
                "cpu": 4,
                "memory": 8,
                "disk": 100
            },
            "config_override": {
                "invoke_import_validation": true,
                "invoke_import_tool": true,
                "invoke_differ_tool": true,
                "skip_input_upload": false,
                "skip_gcs_upload": false,
                "cleanup_gcs_volume_mount": false
            }
        }

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant