Updated manifest.json with cron schedule - #2113
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the manifest.json file for the New York diabetes statistical variable import by adding cron_schedule, resource_limits, and config_override configurations. The review feedback suggests standardizing the indentation of these newly added fields to maintain consistency with the rest of the file's 4-space hierarchy.
| "cron_schedule": "0 0 1 * *", | ||
| "resource_limits": {"cpu": 4, "memory": 8, "disk":100}, | ||
| "config_override": { | ||
| "invoke_import_validation": true, | ||
| "invoke_import_tool": true, | ||
| "invoke_differ_tool": true, | ||
| "skip_input_upload": false, | ||
| "skip_gcs_upload": false, | ||
| "cleanup_gcs_volume_mount": false | ||
| } | ||
| } |
There was a problem hiding this comment.
The indentation of the newly added fields (cron_schedule, resource_limits, and config_override) is inconsistent with the rest of the file. Standardizing the indentation to match the surrounding 4-space hierarchy improves readability and maintainability.
"cron_schedule": "0 0 1 * *",
"resource_limits": {
"cpu": 4,
"memory": 8,
"disk": 100
},
"config_override": {
"invoke_import_validation": true,
"invoke_import_tool": true,
"invoke_differ_tool": true,
"skip_input_upload": false,
"skip_gcs_upload": false,
"cleanup_gcs_volume_mount": false
}
}
Import name =
NewYorkUniversity_DiabetesPR checklist = Doc
Overview
Updated manifest.json with cron schedule
Key Changes