-
Notifications
You must be signed in to change notification settings - Fork 152
NOAA_GPCC_StandardardizedPrecipitation_fix #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
balit-raibot
wants to merge
13
commits into
datacommonsorg:master
Choose a base branch
from
balit-raibot:NOAA_GPCC_StandardardizedPrecipitationIndex_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3fd712b
fixed dataframe columns rendering in NOAA_GPCC_StandardardizedPrecipi…
balit-raibot a119168
fixed dataframe columns rendering in NOAA_GPCC_StandardardizedPrecipi…
balit-raibot 1e8a3f4
adding comments
balit-raibot 0a977e2
adding comments
balit-raibot 3ea1374
Update scripts/noaa/gpcc_spi/preprocess_gpcc_spi.py
balit-raibot 870cf15
adding comments
balit-raibot 04b768d
adding goldens for NOAA GPCC
balit-raibot f783290
Merge branch 'master' into NOAA_GPCC_StandardardizedPrecipitationInde…
balit-raibot eec13d3
adding goldens for NOAA GPCC
balit-raibot bfbf135
Merge branch 'NOAA_GPCC_StandardardizedPrecipitationIndex_fix' of htt…
balit-raibot 96f803c
adding goldens for NOAA GPCC
balit-raibot 272ee9a
Merge branch 'master' into NOAA_GPCC_StandardardizedPrecipitationInde…
balit-raibot 4634ea5
Merge branch 'master' into NOAA_GPCC_StandardardizedPrecipitationInde…
balit-raibot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4,329 changes: 4,329 additions & 0 deletions
4,329
scripts/noaa/gpcc_spi/golden_data/golden_observations_gpcc_spi_aggregation.csv
Large diffs are not rendered by default.
Oops, something went wrong.
3 changes: 3 additions & 0 deletions
3
...ts/noaa/gpcc_spi/golden_data/golden_summary_report_drought_spi_9m_polygon_place_svobs.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| "ScalingFactors","Units","MinDate","observationPeriods","StatVar","MeasurementMethods","NumPlaces" | ||
| "[]","[SquareKilometer]","2010","[P1Y, P1M]","Area_DroughtEvent","[]","14770" | ||
| "[]","[]","2010","[P1Y, P1M]","Count_DroughtEvent","[]","14770" |
3 changes: 3 additions & 0 deletions
3
scripts/noaa/gpcc_spi/golden_data/golden_summary_report_drought_spi_9m_polygon_svobs.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| "StatVar","ScalingFactors","observationPeriods","NumPlaces","Units","MinDate","MeasurementMethods" | ||
| "Area_DroughtEvent","[]","[]","23907","[SquareKilometer]","2010-12","[dcAggregate/PearsonDistribution]" | ||
| "standardizedPrecipitationIndex","[]","[]","23907","[]","2010-12","[dcAggregate/PearsonDistribution]" |
7 changes: 7 additions & 0 deletions
7
scripts/noaa/gpcc_spi/golden_data/golden_summary_report_gpcc_spi.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| "StatVar","observationPeriods","MeasurementMethods","MinDate","ScalingFactors","NumPlaces","Units" | ||
| "StandardizedPrecipitationIndex_Atmosphere_36MonthPeriod","[P36M]","[PearsonDistribution]","2010-12","[]","18967","[]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_1MonthPeriod","[P1M]","[PearsonDistribution]","2010-12","[]","18967","[]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_3MonthPeriod","[P3M]","[PearsonDistribution]","2010-12","[]","18967","[]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_6MonthPeriod","[P6M]","[PearsonDistribution]","2010-12","[]","18967","[]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_72MonthPeriod","[P72M]","[PearsonDistribution]","2010-12","[]","18967","[]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_9MonthPeriod","[P9M]","[PearsonDistribution]","2010-12","[]","18967","[]" |
7 changes: 7 additions & 0 deletions
7
scripts/noaa/gpcc_spi/golden_data/golden_summary_report_gpcc_spi_aggregation.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| "StatVar","MinDate","MeasurementMethods","NumPlaces","Units","ScalingFactors","observationPeriods" | ||
| "StandardizedPrecipitationIndex_Atmosphere_36MonthPeriod","2010-12","[dcAggregate/GridWeightedPearson]","5392","[]","[]","[P36M]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_1MonthPeriod","2010-12","[dcAggregate/GridWeightedPearson]","5392","[]","[]","[P1M]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_3MonthPeriod","2010-12","[dcAggregate/GridWeightedPearson]","5392","[]","[]","[P3M]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_6MonthPeriod","2010-12","[dcAggregate/GridWeightedPearson]","5392","[]","[]","[P6M]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_72MonthPeriod","2010-12","[dcAggregate/GridWeightedPearson]","5392","[]","[]","[P72M]" | ||
| "StandardizedPrecipitationIndex_Atmosphere_9MonthPeriod","2010-12","[dcAggregate/GridWeightedPearson]","5392","[]","[]","[P9M]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "rules": [ | ||
| { | ||
| "rule_id": "check_deleted_records_percent", | ||
| "description": "Checks that the percentage of deleted records for the entire import is within threshold.", | ||
| "validator": "DELETED_RECORDS_PERCENT", | ||
| "params": { "threshold": 0.1} | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_summary_gpcc_spi", | ||
| "description": "Validates gpcc_spi data against its golden summary report.", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report_gpcc_spi.csv", | ||
| "input_files": "../../input0/genmcf/summary_report.csv" | ||
| } | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_summary_gpcc_spi_aggregation", | ||
| "description": "Validates gpcc_spi_aggregation data against its golden summary report.", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report_gpcc_spi_aggregation.csv", | ||
| "input_files": "../../input1/genmcf/summary_report.csv" | ||
| } | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_summary_drought_spi_9m_polygon_place_svobs", | ||
| "description": "Validates drought_spi_9m_polygon_place_svobs data against its golden summary report.", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report_drought_spi_9m_polygon_place_svobs.csv", | ||
| "input_files": "../../input2/genmcf/summary_report.csv" | ||
| } | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_summary_drought_spi_9m_polygon_svobs", | ||
| "description": "Validates drought_spi_9m_polygon_svobs data against its golden summary report.", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report_drought_spi_9m_polygon_svobs.csv", | ||
| "input_files": "../../input4/genmcf/summary_report.csv" | ||
| } | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_output_csv_gpcc_spi_aggregation", | ||
| "description": "Verifies the generated gpcc_spi_aggregation output CSV data matches established critical golden records", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_observations_gpcc_spi_aggregation.csv", | ||
| "input_files": "../../../../output_files/aggregations/*.csv" | ||
| } | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.