Skip to content

Revert "Fix ci and benchmarks (#581)" - #584

Merged
ianconsolata merged 1 commit into
developfrom
revert-581-fix-ci-and-benchmarks
Oct 14, 2025
Merged

Revert "Fix ci and benchmarks (#581)"#584
ianconsolata merged 1 commit into
developfrom
revert-581-fix-ci-and-benchmarks

Conversation

@ianconsolata

Copy link
Copy Markdown
Collaborator

This reverts commit 6c6c640.

@parkan
parkan force-pushed the revert-581-fix-ci-and-benchmarks branch from c89af4f to 408dacd Compare October 2, 2025 10:42
@parkan

parkan commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

force-pushing rebased version as that's cleaner than fixing in merge commit, conflicts were due to a stray import and what looked to be a failed rerere (table clearing code that was added twice)

@parkan

parkan commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

ugh ok I am going to take a slightly more surgical approach here

@parkan

parkan commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator
  • for docgen: fix db init #552 is the simplest fix, though thinking about whether we want the docs generated in CI or locally is worthwhile
  • for the other failing db issues... complex orchestration here is just going to be an ongoing nightmare to debug and maintain, giving Experimental test workflow with devcontainer #585 another go because it's honestly a lot easier to manage (and is isomorphic with local dev workflow)
  • for the handful of useful changes in the originally reverted PR, I'm looking to see if it makes sense to re-apply them separately or exclude from this revert PR, leaning towards the former

@parkan

parkan commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

@ianconsolata let's just merge this, I have a clean CI workflow pretty much ready in #585 but it's a bit tricky to develop without this merged

there are other commits we may want to revert on develop but I don't want to just throw away the whole branch given that a bunch of work is based on it; I think it'll be easier to do surgical reverts as needed

@ianconsolata
ianconsolata merged commit d568231 into develop Oct 14, 2025
5 of 13 checks passed
@ianconsolata
ianconsolata deleted the revert-581-fix-ci-and-benchmarks branch October 14, 2025 18:39
parkan pushed a commit that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants