Revert "Fix ci and benchmarks (#581)" - #584
Merged
Merged
Conversation
This reverts commit 6c6c640.
parkan
force-pushed
the
revert-581-fix-ci-and-benchmarks
branch
from
October 2, 2025 10:42
c89af4f to
408dacd
Compare
Collaborator
|
force-pushing rebased version as that's cleaner than fixing in merge commit, conflicts were due to a stray import and what looked to be a failed rerere (table clearing code that was added twice) |
Collaborator
|
ugh ok I am going to take a slightly more surgical approach here |
Collaborator
|
Collaborator
|
@ianconsolata let's just merge this, I have a clean CI workflow pretty much ready in #585 but it's a bit tricky to develop without this merged there are other commits we may want to revert on develop but I don't want to just throw away the whole branch given that a bunch of work is based on it; I think it'll be easier to do surgical reverts as needed |
parkan
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6c6c640.