Skip to content

feat(key-wallet): owner-tagged reservations to close the broadcast-release TOCTOU (platform#4185) - #916

Merged
xdustinface merged 8 commits into
dashpay:devfrom
bfoss765:feat/owner-tagged-reservations
Aug 5, 2026
Merged

feat(key-wallet): owner-tagged reservations to close the broadcast-release TOCTOU (platform#4185)#916
xdustinface merged 8 commits into
dashpay:devfrom
bfoss765:feat/owner-tagged-reservations

refactor(key-wallet): address reservation review feedback

5ade591
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 4, 2026 in 0s

74.75% (-0.01%) compared to 9cbe4e7

View this Pull Request on Codecov

74.75% (-0.01%) compared to 9cbe4e7

Details

Codecov Report

❌ Patch coverage is 91.05263% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.75%. Comparing base (9cbe4e7) to head (5ade591).

Files with missing lines Patch % Lines
...c/wallet/managed_wallet_info/asset_lock_builder.rs 79.68% 13 Missing ⚠️
.../src/managed_account/managed_core_funds_account.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #916      +/-   ##
==========================================
- Coverage   74.76%   74.75%   -0.01%     
==========================================
  Files         328      328              
  Lines       76593    76700     +107     
==========================================
+ Hits        57267    57340      +73     
- Misses      19326    19360      +34     
Files with missing lines Coverage Δ
key-wallet/src/managed_account/reservation.rs 100.00% <100.00%> (ø)
.../wallet/managed_wallet_info/transaction_builder.rs 87.33% <100.00%> (+0.27%) ⬆️
...wallet/managed_wallet_info/transaction_building.rs 87.87% <100.00%> (ø)
.../src/managed_account/managed_core_funds_account.rs 78.99% <0.00%> (-0.70%) ⬇️
...c/wallet/managed_wallet_info/asset_lock_builder.rs 89.61% <79.68%> (-1.11%) ⬇️

... and 20 files with indirect coverage changes