Skip to content

fix(key-wallet): out-of-order UTXO spend recorded nowhere — phantom unspent balance (#649) - #909

Merged
QuantumExplorer merged 10 commits into
dashpay:devfrom
bfoss765:fix/wallet-utxo-spend-not-marked-649
Aug 6, 2026
Merged

fix(key-wallet): out-of-order UTXO spend recorded nowhere — phantom unspent balance (#649)#909
QuantumExplorer merged 10 commits into
dashpay:devfrom
bfoss765:fix/wallet-utxo-spend-not-marked-649

test(key-wallet-manager): name the out-of-order repro after the invar…

c25cdd4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 5, 2026 in 0s

74.82% (+0.07%) compared to 8f78baa

View this Pull Request on Codecov

74.82% (+0.07%) compared to 8f78baa

Details

Codecov Report

❌ Patch coverage is 89.13043% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.82%. Comparing base (8f78baa) to head (c25cdd4).

Files with missing lines Patch % Lines
...-wallet/src/managed_account/managed_account_ref.rs 50.00% 16 Missing ⚠️
key-wallet/src/wallet/managed_wallet_info/mod.rs 89.04% 8 Missing ⚠️
...allet/managed_wallet_info/wallet_info_interface.rs 25.00% 6 Missing ⚠️
...src/wallet/managed_wallet_info/managed_accounts.rs 33.33% 4 Missing ⚠️
key-wallet-manager/src/process_block.rs 0.00% 3 Missing ⚠️
key-wallet-manager/src/wallet_interface.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #909      +/-   ##
==========================================
+ Coverage   74.75%   74.82%   +0.07%     
==========================================
  Files         328      328              
  Lines       76700    77044     +344     
==========================================
+ Hits        57337    57651     +314     
- Misses      19363    19393      +30     
Files with missing lines Coverage Δ
dash-spv/src/sync/filters/batch.rs 97.60% <100.00%> (ø)
dash-spv/src/sync/filters/manager.rs 97.86% <100.00%> (+0.11%) ⬆️
key-wallet/src/managed_account/address_pool.rs 79.22% <100.00%> (+0.11%) ⬆️
.../src/managed_account/managed_core_funds_account.rs 79.57% <100.00%> (+0.58%) ⬆️
...-wallet/src/transaction_checking/wallet_checker.rs 99.24% <100.00%> (+<0.01%) ⬆️
key-wallet-manager/src/process_block.rs 90.53% <0.00%> (-0.64%) ⬇️
key-wallet-manager/src/wallet_interface.rs 10.34% <0.00%> (-1.20%) ⬇️
...src/wallet/managed_wallet_info/managed_accounts.rs 35.34% <33.33%> (+6.64%) ⬆️
...allet/managed_wallet_info/wallet_info_interface.rs 76.36% <25.00%> (-1.54%) ⬇️
key-wallet/src/wallet/managed_wallet_info/mod.rs 75.00% <89.04%> (+8.61%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes