Skip to content

feat(platform-wallet): pool BIP44 + BIP32 + DashPay receiving funds on the asset-lock path #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 7 commits into from
Aug 10, 2026
+941 −235
Merged

feat(platform-wallet): pool BIP44 + BIP32 + DashPay receiving funds on the asset-lock path #4350

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72e89a3
feat(platform-wallet): pool BIP44 + BIP32 + DashPay receiving funds o…
bfoss765 Aug 9, 2026
fe4a1b3
chore: repoint rust-dashcore deps to dashpay-owned repo
bfoss765 Aug 10, 2026
8b7c23d
test(platform-wallet): cover BIP32 and DashPay families in funding_tx…
bfoss765 Aug 10, 2026
2678748
chore: repoint rust-dashcore deps to the merged dev revision
bfoss765 Aug 10, 2026
64cc292
fix(platform-wallet): close the three pooled-funding blocker gaps
bfoss765 Aug 10, 2026
8f5d6ec
docs: complete the pooled-funding contract on the two missed surfaces
bfoss765 Aug 10, 2026
5387517
docs: pooled-funding contract on the remaining foreign surfaces
bfoss765 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ members = [
]

[workspace.dependencies]
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "b056d07c61f8618f05082552bbb88072290d57c1" }
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }
key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "5a80bd71f6ba13a5055780d644f0aa724a34ca04" }

tokio-metrics = "0.5"

Expand Down
8 changes: 8 additions & 0 deletions packages/rs-platform-wallet-ffi/src/asset_lock/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ use std::os::raw::c_char;

/// Build an asset lock transaction via an external mnemonic resolver.
///
/// Funding is POOLED across `platform_wallet::ASSET_LOCK_FUNDING_SOURCES`:
/// coin selection draws from the union of the BIP44 and BIP32 accounts at
/// `account_index` plus every DashPay contact-receiving account, and change
/// returns to BIP44. A lock therefore no longer needs its whole amount sitting
/// in one account, and the caller no longer has to sweep accounts together
/// first. `account_index` addresses the standard families only; DashPay
/// accounts span their own indices and are pooled in regardless.
///
/// On success:
/// - `out_tx_bytes`/`out_tx_len`: serialized signed transaction
/// - `out_derivation_path`: NUL-terminated C string with the
Expand Down
4 changes: 3 additions & 1 deletion packages/rs-platform-wallet/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ pub use wallet::asset_lock::manager::AssetLockManager;
pub use wallet::asset_lock::tracked::{AssetLockStatus, TrackedAssetLock};
pub use wallet::asset_lock::AssetLockFunding;
pub use wallet::core::WalletBalance;
pub use wallet::core::{CoreWallet, SignedCoreTransaction, SEND_FUNDING_SOURCES};
pub use wallet::core::{
CoreWallet, SignedCoreTransaction, ASSET_LOCK_FUNDING_SOURCES, SEND_FUNDING_SOURCES,
};
pub use wallet::signed_payment_registry::{
RegisterWrongGeneration, ReservationToken, SignedPaymentError, SignedPaymentRegistry,
};
Expand Down
Loading
Loading