Skip to content

fix(dpp): make document type index update validation name-order independent #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 7 commits into from
Aug 5, 2026
Merged

fix(dpp): make document type index update validation name-order independent #4291

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6dab3cf
fix(dpp): make document type index update validation name-order indep…
QuantumExplorer Aug 5, 2026
bc5ad1b
Merge remote-tracking branch 'origin/v4.2-dev' into claude/practical-…
QuantumExplorer Aug 5, 2026
23f40c6
test(dpp): move ranked-index update tests to validate_update v1
QuantumExplorer Aug 5, 2026
17cd413
test(dpp): cover remaining validate_config guards and pin v0 late-nam…
QuantumExplorer Aug 5, 2026
5078c6a
test(dpp): pin validate_update v1 tests to protocol version 14
QuantumExplorer Aug 5, 2026
da84076
Revert "test(dpp): pin validate_update v1 tests to protocol version 14"
QuantumExplorer Aug 5, 2026
ae98e86
test(dpp): match the exact schema-compat error variant in v0 pin test
QuantumExplorer Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,712 changes: 1,712 additions & 0 deletions packages/rs-dpp/src/data_contract/document_type/methods/validate_update/common/mod.rs
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion packages/rs-dpp/src/data_contract/document_type/methods/validate_update/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ use crate::validation::SimpleConsensusValidationResult;
use crate::ProtocolError;
use platform_version::version::PlatformVersion;

mod common;
mod v0;
mod v1;

impl DocumentTypeRef<'_> {
/// Verify that the update to the document type is valid.
Expand All @@ -20,9 +22,10 @@ impl DocumentTypeRef<'_> {
.validate_update
{
0 => self.validate_update_v0(new_document_type, platform_version),
1 => self.validate_update_v1(new_document_type, platform_version),
version => Err(ProtocolError::UnknownVersionMismatch {
method: "validate_update".to_string(),
known_versions: vec![0],
known_versions: vec![0, 1],
received: version,
}),
}
Expand Down
Loading
Loading