feat(sdk): expose OP_RETURN, output-order and change-to-VIN0 controls

.github/workflows/tests-rs-workspace.yml

@@ -38,6 +38,13 @@ jobs:
         with:
           clean: false
 
+      - name: Fail on local rust-dashcore patch override
+        run: |
+          if grep -q '^\[patch\."https://github.com/dashpay/rust-dashcore"\]' Cargo.toml; then
+            echo "::error::Remove the local rust-dashcore [patch] override before merging"
+            exit 1
+          fi
+
       # target/llvm-cov-target is deliberately NOT pruned here: it holds the
       # coverage-instrumented build (~10GB) that makes the test step's compile
       # incremental (~2.5 min saved per run). The size/free-disk guard below

Cargo.toml

@@ -52,14 +52,14 @@ members = [
 ]
 
 [workspace.dependencies]
-dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
-dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
-dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
-key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
-key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
-key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
-dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
-dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "08bf729de819f52973002f754342fedac14a06db" }
+dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
+dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
+dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
+key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
+key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
+key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
+dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
+dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "dca5b05b83a9a2d6fd7b650e7cce4356d1c2ec29" }
 
 tokio-metrics = "0.5"
 

packages/rs-platform-wallet-ffi/src/core_wallet/broadcast.rs

@@ -173,6 +173,28 @@ pub unsafe extern "C" fn core_wallet_signed_transaction_v2_fee(
     PlatformWalletFFIResult::ok()
 }
 
+#[no_mangle]
+pub unsafe extern "C" fn core_wallet_signed_transaction_v2_bytes(
+    transaction_handle: Handle,
+    out_bytes: *mut *mut u8,
+    out_len: *mut usize,
+) -> PlatformWalletFFIResult {
+    check_ptr!(out_bytes);
+    check_ptr!(out_len);
+    *out_bytes = std::ptr::null_mut();
+    *out_len = 0;
+
+    let bytes = unwrap_option_or_return!(CORE_SIGNED_TRANSACTION_V2_STORAGE
+        .with_item(transaction_handle, |tx| dashcore::consensus::serialize(
+            tx.transaction.transaction()
+        )));
+    let len = bytes.len();
+    let boxed = bytes.into_boxed_slice();
+    *out_bytes = Box::into_raw(boxed) as *mut u8;
+    *out_len = len;
+    PlatformWalletFFIResult::ok()
+}
+
 /// Broadcast a transaction built by `core_wallet_tx_builder_build_signed`.
 ///
 /// `account_type`/`account_index` identify the funding account handed to

packages/rs-platform-wallet-ffi/src/core_wallet/transaction_builder.rs

@@ -13,7 +13,9 @@ use key_wallet::managed_account::managed_account_trait::ManagedAccountTrait;
 use key_wallet::managed_account::ManagedCoreFundsAccount;
 use key_wallet::wallet::managed_wallet_info::coin_selection::SelectionStrategy;
 use key_wallet::wallet::managed_wallet_info::fee::FeeRate;
-use key_wallet::wallet::managed_wallet_info::transaction_builder::TransactionBuilder;
+use key_wallet::wallet::managed_wallet_info::transaction_builder::{
+    TransactionBuilder, MAX_STANDARD_OP_RETURN_BYTES,
+};
 use key_wallet::wallet::managed_wallet_info::transaction_building::AccountTypePreference;
 use key_wallet::wallet::managed_wallet_info::wallet_info_interface::WalletInfoInterface;
 use rs_sdk_ffi::{MnemonicResolverCoreSigner, MnemonicResolverHandle};
@@ -508,6 +510,57 @@ pub unsafe extern "C" fn core_wallet_tx_builder_add_output(
     PlatformWalletFFIResult::ok()
 }
 
+/// Add a zero-value OP_RETURN output carrying `data`.
+///
+/// # Safety
+/// `builder` must be a valid, non-destroyed pointer; `data` must reference a
+/// readable buffer of `data_len` bytes when `data_len > 0`.
+#[no_mangle]
+pub unsafe extern "C" fn core_wallet_tx_builder_add_op_return(
+    builder: *mut FFITransactionBuilder,
+    data: *const u8,
+    data_len: usize,
+) -> PlatformWalletFFIResult {
+    check_ptr!(builder);
+    if data_len > 0 {
+        check_ptr!(data);
+    }
+
+    let bytes = if data_len == 0 {
+        &[]
+    } else {
+        std::slice::from_raw_parts(data, data_len)
+    };
+
+    // `add_op_return` takes the builder by value, so a rejected payload drops it and leaves
+    // `take_builder`'s `mem::take` default behind — silently discarding outputs and options
+    // the caller already configured. Reject an over-long payload *before* taking the builder
+    // so the slot keeps its real state. `add_op_return` re-checks; this is the same policy
+    // constant, not a second opinion.
+    if data_len > MAX_STANDARD_OP_RETURN_BYTES {
+        return PlatformWalletFFIResult::err(
+            PlatformWalletFFIResultCode::ErrorInvalidParameter,
+            format!(
+                "OP_RETURN payload too large: {data_len} bytes (max {MAX_STANDARD_OP_RETURN_BYTES})"
+            ),
+        );
+    }
+
+    let b = (*builder).take_builder();
+    let b = match b.add_op_return(bytes) {
+        Ok(b) => b,
+        Err(err) => {
+            return PlatformWalletFFIResult::err(
+                PlatformWalletFFIResultCode::ErrorWalletOperation,
+                err.to_string(),
+            );
+        }
+    };
+    (*builder).store_builder(b);
+
+    PlatformWalletFFIResult::ok()
+}
+
 /// # Safety
 /// `builder` must be a valid, non-destroyed pointer; `address` a valid NUL-terminated C string.
 #[no_mangle]
@@ -538,6 +591,40 @@ pub unsafe extern "C" fn core_wallet_tx_builder_set_change_address(
     PlatformWalletFFIResult::ok()
 }
 
+/// Preserve outputs in the order they were added instead of applying BIP-69 sorting.
+///
+/// # Safety
+/// `builder` must be a valid, non-destroyed pointer.
+#[no_mangle]
+pub unsafe extern "C" fn core_wallet_tx_builder_preserve_output_order(
+    builder: *mut FFITransactionBuilder,
+) -> PlatformWalletFFIResult {
+    check_ptr!(builder);
+
+    let b = (*builder).take_builder();
+    let b = b.preserve_output_order();
+    (*builder).store_builder(b);
+
+    PlatformWalletFFIResult::ok()
+}
+
+/// Route change to the address of the first selected input (VIN0).
+///
+/// # Safety
+/// `builder` must be a valid, non-destroyed pointer.
+#[no_mangle]
+pub unsafe extern "C" fn core_wallet_tx_builder_change_to_first_input(
+    builder: *mut FFITransactionBuilder,
+) -> PlatformWalletFFIResult {
+    check_ptr!(builder);
+
+    let b = (*builder).take_builder();
+    let b = b.change_to_first_input();
+    (*builder).store_builder(b);
+
+    PlatformWalletFFIResult::ok()
+}
+
 /// # Safety
 /// `builder` must be a valid, non-destroyed pointer.
 #[no_mangle]