backport: bitcoin#18628, #19393, #25204, #25689, #25785, bitcoin-core/gui#613

[knst]

What was done?

Regular backports from Bitcoin Core v24

How Has This Been Tested?

Run unit & functional tests

Breaking Changes

Removed command line option -deprecatedrpc=fees and relevant RPC output.

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[thepastaclaw]

✅ Final review complete — no blockers (commit 452481a)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c9946be-3ac2-4533-946c-a581799aaa2e

📥 Commits

Reviewing files that changed from the base of the PR and between dc1d21e and 452481a.

📒 Files selected for processing (9)

• src/Makefile.bench.include
• src/bench/descriptors.cpp
• src/net_processing.cpp
• src/qt/rpcconsole.cpp
• src/rpc/mempool.cpp
• src/test/fuzz/tx_pool.cpp
• test/functional/p2p_invalid_tx.py
• test/functional/rpc_mempool_entry_fee_fields_deprecation.py
• test/functional/test_runner.py

💤 Files with no reviewable changes (4)

• src/rpc/mempool.cpp
• src/qt/rpcconsole.cpp
• test/functional/rpc_mempool_entry_fee_fields_deprecation.py
• test/functional/test_runner.py

---

Walkthrough

The PR updates block-connected orphan transaction cleanup and expands functional coverage for orphan rejection, peer cleanup, inclusion, and conflicts. It removes deprecated top-level mempool fee fields and their functional test. Transaction-pool fuzz targets now initialize constraints after setup and keep them fixed per iteration. It adds a descriptor expansion benchmark, removes unused wallet database includes, and registers the benchmark source.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Peer
  participant BlockConnected
  participant OrphanPool
  participant Mempool
  Peer->>BlockConnected: submit block
  BlockConnected->>OrphanPool: erase included or conflicting orphans
  BlockConnected->>OrphanPool: reconsider remaining orphans
  OrphanPool->>Mempool: accept newly valid transactions

Loading

Possibly related PRs

• dashpay/dash#7514: Related changes in src/net_processing.cpp involving orphan transaction handling.
• dashpay/dash#7525: Related changes in src/rpc/mempool.cpp and src/test/fuzz/tx_pool.cpp involving mempool behavior.

Suggested reviewers: pastapastapasta

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the pull request as a backport of specific Bitcoin Core and GUI changes.
Description check	✅ Passed	The description explains the backport scope, testing performed, and breaking RPC changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

Final validation — Codex + Opus

The backported production and test changes are technically sound, and no build, runtime, consensus, or Dash-subsystem blockers were confirmed. The branch should still document the breaking mempool RPC field removal and exclude the unrelated #7544 LLMQ merge; the standalone orphan-ordering fix also needs a durable commit message.

Review provenance

• Codex reviewers: gpt-5.6-sol — general (completed), gpt-5.6-sol — dash-core-commit-history (completed), gpt-5.6-sol — backport-reviewer (completed)
• Verifier: gpt-5.6-sol — final-verifier (Opus verifier fallback)
• Opus reviewers: claude-sonnet-5 — general (failed), claude-sonnet-5 — dash-core-commit-history (failed), claude-sonnet-5 — backport-reviewer (completed), claude-sonnet-5 — general (completed), claude-sonnet-5 — dash-core-commit-history (failed), claude-sonnet-5 — dash-core-commit-history (completed)

🟡 2 suggestion(s) | 💬 1 nitpick(s)

3 additional finding(s) omitted (not in diff).

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `src/rpc/mempool.cpp`:
- [SUGGESTION] src/rpc/mempool.cpp:245-287: Breaking RPC change lacks a release-notes entry
  Add a `doc/release-notes-7551.md` fragment documenting this removal. The backport eliminates `-deprecatedrpc=fees` and the top-level `fee`, `modifiedfee`, `ancestorfees`, and `descendantfees` fields from all RPCs that expose this shared mempool-entry representation. Upstream bitcoin#25204 included commit `885694d7941`, which explicitly documented the removal, and merge commit `13336e83ec0` lists that commit while omitting its documentation hunk. Dash uses per-PR release-note fragments for equivalent user-facing RPC changes, and the earlier Dash release notes only announce these fields as deprecated, so users currently have no release-note record that the compatibility option and fields are now gone.

In `<commit:dc1d21e>`:
- [SUGGESTION] <commit:dc1d21e>:1: Remove the unrelated #7544 merge from this PR stack
  Commit `dc1d21ea81b` is a true two-parent merge of PR #7544 that adds an unrelated LLMQ `IsQuorumActive` change before the advertised Bitcoin Core backports. Nothing in the subsequent RPC, GUI, fuzz, benchmark, or orphan-transaction changes depends on this guard. Landing the branch as-is would attribute #7544's behavior to both PRs and add unrelated merge topology. Rebase this branch after #7544 lands independently, or rebuild it from `43ec910c250` without `dc1d21ea81b` and its side commits.

[PastaPastaPasta]

In src/rpc/mempool.cpp:

• [SUGGESTION] src/rpc/mempool.cpp:245-287: Breaking RPC change lacks a release-notes entry
  Add a doc/release-notes-7551.md fragment documenting this removal. The backport eliminates -deprecatedrpc=fees and the top-level fee, modifiedfee, ancestorfees, and descendantfees fields from all RPCs that expose this shared mempool-entry representation. Upstream rpc: remove deprecated top-level fee fields from mempool entries bitcoin/bitcoin#25204 included commit 885694d7941, which explicitly documented the removal, and merge commit 13336e83ec0 lists that commit while omitting its documentation hunk. Dash uses per-PR release-note fragments for equivalent user-facing RPC changes, and the earlier Dash release notes only announce these fields as deprecated, so users currently have no release-note record that the compatibility option and fields are now gone.