Skip to content

perf: check quorum activity before materializing the quorum on QSIGREC #7531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 2 commits into from
Aug 4, 2026
Merged

perf: check quorum activity before materializing the quorum on QSIGREC #7531

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcdc0fa
perf(llmq): check quorum activity before materializing the quorum on …
PastaPastaPasta Aug 3, 2026
5619e24
refactor: trim comment density in VerifyAndProcessRecoveredSig
PastaPastaPasta Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/llmq/signing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,14 +366,15 @@ bool CSigningManager::GetRecoveredSigForGetData(const uint256& hash, CRecoveredS
void CSigningManager::VerifyAndProcessRecoveredSig(NodeId from, std::shared_ptr<CRecoveredSig> recoveredSig)
{
auto llmq_type = recoveredSig->getLlmqType();
auto quorum = qman.GetQuorum(llmq_type, recoveredSig->getQuorumHash());

if (!quorum) {
LogPrint(BCLog::LLMQ, "CSigningManager::%s -- quorum %s not found\n", __func__,
recoveredSig->getQuorumHash().ToString());
return;
}
if (!IsQuorumActive(llmq_type, qman, quorum->qc->quorumHash)) {
const uint256& quorum_hash = recoveredSig->getQuorumHash();

// Cheap gate first. IsQuorumActive is bounded to the keepOldConnections most recent
// quorums at the tip, and that set is shared and cached across callers. GetQuorum, by
// contrast, takes the peer-supplied hash and can rebuild an arbitrary historical mined
// commitment (DMN list replay + member selection) on a cache miss — do not let an
// unsolicited QSIGREC force that work for inactive hashes.
// Caller (NetSigning) has already rejected unknown llmq types.
if (!IsQuorumActive(llmq_type, qman, quorum_hash)) {
return;
}

Expand All @@ -383,6 +384,19 @@ void CSigningManager::VerifyAndProcessRecoveredSig(NodeId from, std::shared_ptr<
return;
}

// Once IsQuorumActive has passed, quorum_hash is one of the recent quorums ScanQuorums
// covers, so this is usually served from cache. ScanQuorums and GetQuorum keep separate
// LRUs, so a rebuild is still possible here, but only of a recent quorum — never of the
// arbitrary historical one a peer could otherwise name.
auto quorum = qman.GetQuorum(llmq_type, quorum_hash);
if (!quorum) {
// Reported active by ScanQuorums but no longer materializable (e.g. reorg).
// Not peer-controlled once the hash is restricted to the active set, so no score.
LogPrint(BCLog::LLMQ, "CSigningManager::%s -- quorum %s not found\n", __func__,
quorum_hash.ToString());
return;
}

LogPrint(BCLog::LLMQ, "CSigningManager::%s -- signHash=%s, id=%s, msgHash=%s, node=%d\n", __func__,
recoveredSig->buildSignHash().ToString(), recoveredSig->getId().ToString(), recoveredSig->getMsgHash().ToString(), from);

Expand Down