Skip to content

fix: score peers requesting an unregistered LLMQType via QGETDATA #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 1 commit into from
Aug 3, 2026
+10 −4
Merged

fix: score peers requesting an unregistered LLMQType via QGETDATA #7529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/llmq/net_quorum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,11 @@ void NetQuorum::ProcessMessage(CNode& pfrom, const std::string& msg_type, CDataS
const bool request_limit_exceeded = !m_qman.RegisterDataRequest(key, request, /*add_expiry_bias=*/false);

if (!Params().GetLLMQ(request.GetLLMQType()).has_value()) {
if (sendQDATA(CQuorumDataRequest::Errors::QUORUM_TYPE_INVALID, request_limit_exceeded)) {
m_peer_manager->PeerMisbehaving(pfrom.GetId(), 25, "request limit exceeded");
}
// Unlike the misses below, this one cannot be explained by the peer being ahead of

@knst knst Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be explained by the peer being far ahead of us - if we had miss a new fork that introduced new version with new quorum.

peer ban is fine here, because we can't sync anyway from him but the comment is wrong.

// us: no quorum of an unregistered type can exist on this chain, so there is
// nothing to ask about. Answer with the error anyway, then score in full.
sendQDATA(CQuorumDataRequest::Errors::QUORUM_TYPE_INVALID, request_limit_exceeded);
m_peer_manager->PeerMisbehaving(pfrom.GetId(), 100, "invalid llmqType in QGETDATA");
return;
}

Expand Down
6 changes: 5 additions & 1 deletion test/functional/p2p_quorum_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,14 @@ def send_bad_qdata_expect_disconnect(bad_qdata):
qgetdata_invalid_block = msg_qgetdata(protx_hash_int, 100, 0x01, protx_hash_int)
qgetdata_invalid_quorum = msg_qgetdata(int(mn2.get_node(self).getblockhash(0), 16), 100, 0x01, protx_hash_int)
qgetdata_invalid_no_member = msg_qgetdata(quorum_hash_int, 100, 0x02, quorum_hash_int)
p2p_mn2.test_qgetdata(qgetdata_invalid_type, QUORUM_TYPE_INVALID)
p2p_mn2.test_qgetdata(qgetdata_invalid_block, QUORUM_BLOCK_NOT_FOUND)
p2p_mn2.test_qgetdata(qgetdata_invalid_quorum, QUORUM_NOT_FOUND)
p2p_mn2.test_qgetdata(qgetdata_invalid_no_member, MASTERNODE_IS_NO_MEMBER)
# An unregistered LLMQ type is answered like the misses above, but unlike them it
# cannot be explained by the peer being ahead of us, so it is scored in full too.
# Kept last: the peer is dropped once it is.
p2p_mn2.test_qgetdata(qgetdata_invalid_type, QUORUM_TYPE_INVALID)
self.wait_until(lambda: not p2p_mn2.is_connected, timeout=10)
# The last two error case require the node to miss its DKG data so we just reindex the node.
mn2.get_node(self).disconnect_p2ps()
self.restart_mn(mn1, reindex=True)
Expand Down
Loading