chore(deps): track platform PR #3968 branch for wallet-storage rehydration - #940
Conversation
…ation Switches dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage from a pinned rev to branch tracking of dashpay/platform#3968 (feat/platform-wallet-storage-rehydration), so Cargo resolves its current HEAD instead of a fixed commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough
ChangesDependency branch tracking
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Cargo.toml (1)
23-23: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the shared platform git dependencies to an immutable revision before release.
dash-sdk,rs-sdk-trusted-context-provider,platform-wallet, andplatform-wallet-storagestill declarebranch = "feat/platform-wallet-storage-rehydration"inCargo.toml; whileCargo.lockcurrently resolves them to the same commit,cargo updatecan move those branch-pinned crates. Replace the branch references with a fixedrevpin once the upstream change is available, and keep releases locked with Cargo’s locked mode.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Cargo.toml` at line 23, Update the shared platform dependencies dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage in Cargo.toml to replace the feature branch reference with the upstream immutable commit revision, preserving their existing features and dependency configuration. Ensure Cargo.lock records the same revision so locked releases remain reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Cargo.toml`:
- Line 23: Update the shared platform dependencies dash-sdk,
rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage in
Cargo.toml to replace the feature branch reference with the upstream immutable
commit revision, preserving their existing features and dependency
configuration. Ensure Cargo.lock records the same revision so locked releases
remain reproducible.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 26899aa8-ca7d-4b23-9433-3c0e6a672e01
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
feat/platform-wallet-storage-rehydration moved 0ed8b4d1 -> debf67bd since this branch was last synced. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ation (dashpay#940) * chore(deps): track platform PR #3968 branch for wallet-storage rehydration Switches dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage from a pinned rev to branch tracking of dashpay/platform#3968 (feat/platform-wallet-storage-rehydration), so Cargo resolves its current HEAD instead of a fixed commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * chore(deps): bump platform PR #3968 pin to latest branch HEAD feat/platform-wallet-storage-rehydration moved 0ed8b4d1 -> debf67bd since this branch was last synced. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit 3e05d5f)
TL;DR
Points this app's Dash Platform dependency at the in-progress work for embeddable SQLite wallet-storage persistence (with seedless rehydration), so it stays current with that work automatically instead of needing a manual re-pin on every commit.
Detailed discussion
dash-sdk,rs-sdk-trusted-context-provider,platform-wallet, andplatform-wallet-storagewere pinned to a fixed commit (rev = "288a6cae...") ondashpay/platform. This switches all four tobranch = "feat/platform-wallet-storage-rehydration"— the head branch of dashpay/platform#3968, currently open — soCargo.locktracks that branch's HEAD rather than a one-time snapshot.Cargo.lockwas regenerated (cargo update -p dash-sdk -p platform-wallet -p platform-wallet-storage -p rs-sdk-trusted-context-provider), pulling in the branch's current tip (0ed8b4d1) and bumping the affected platform crates from4.1.0-rc.1to4.1.0.This is a temporary branch tracking pin, not a permanent arrangement — intended to ride PR #3968 while it's in review, and should be re-pinned to a fixed
rev(or dropped in favor of whateverdashpay/platform#3968merges to) once that PR lands.Testing
cargo-cached.sh clippy --bin dash-evo-tool --all-features -- -D warnings— clean, exit 0.cargo fmt --all— clean, no changes needed beyond the dependency edits.git diff --check— clean.tests.yml/clippy.yml), which this diff'sCargo.toml/Cargo.lockchanges will trigger.Breaking changes
None to this app's own code — dependency-tracking change only. Note: since this tracks a branch rather than a fixed commit, a future push to
feat/platform-wallet-storage-rehydrationupstream will changeCargo.lock's resolved commit on the nextcargo updatewithout any corresponding commit in this repo — worth knowing before merging as a base for other work.Attribution
🤖 Co-authored by Claudius the Magnificent AI Agent
Summary by CodeRabbit