Skip to content

chore(deps): track platform PR #3968 branch for wallet-storage rehydration - #940

Merged
lklimek merged 2 commits into
v1.0-devfrom
chore/pin-platform-pr3968-branch
Jul 28, 2026
Merged

chore(deps): track platform PR #3968 branch for wallet-storage rehydration#940
lklimek merged 2 commits into
v1.0-devfrom
chore/pin-platform-pr3968-branch

Conversation

@Claudius-Maginificent

@Claudius-Maginificent Claudius-Maginificent commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

TL;DR

Points this app's Dash Platform dependency at the in-progress work for embeddable SQLite wallet-storage persistence (with seedless rehydration), so it stays current with that work automatically instead of needing a manual re-pin on every commit.

Detailed discussion

dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage were pinned to a fixed commit (rev = "288a6cae...") on dashpay/platform. This switches all four to branch = "feat/platform-wallet-storage-rehydration" — the head branch of dashpay/platform#3968, currently open — so Cargo.lock tracks that branch's HEAD rather than a one-time snapshot.

Cargo.lock was regenerated (cargo update -p dash-sdk -p platform-wallet -p platform-wallet-storage -p rs-sdk-trusted-context-provider), pulling in the branch's current tip (0ed8b4d1) and bumping the affected platform crates from 4.1.0-rc.1 to 4.1.0.

This is a temporary branch tracking pin, not a permanent arrangement — intended to ride PR #3968 while it's in review, and should be re-pinned to a fixed rev (or dropped in favor of whatever dashpay/platform#3968 merges to) once that PR lands.

Testing

  • cargo-cached.sh clippy --bin dash-evo-tool --all-features -- -D warnings — clean, exit 0.
  • cargo fmt --all — clean, no changes needed beyond the dependency edits.
  • git diff --check — clean.
  • Full workspace test/clippy sweep left to CI (tests.yml/clippy.yml), which this diff's Cargo.toml/Cargo.lock changes will trigger.

Breaking changes

None to this app's own code — dependency-tracking change only. Note: since this tracks a branch rather than a fixed commit, a future push to feat/platform-wallet-storage-rehydration upstream will change Cargo.lock's resolved commit on the next cargo update without any corresponding commit in this repo — worth knowing before merging as a base for other work.

Attribution

🤖 Co-authored by Claudius the Magnificent AI Agent

Summary by CodeRabbit

  • Chores
    • Updated internal wallet and SDK components to align with the latest development updates.
    • No direct user-facing changes are included in this release.

…ation

Switches dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and
platform-wallet-storage from a pinned rev to branch tracking of
dashpay/platform#3968 (feat/platform-wallet-storage-rehydration), so
Cargo resolves its current HEAD instead of a fixed commit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f728d2d-be8b-43be-9551-eac5a0d3a6d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Cargo.toml switches four git dependencies from pinned revisions to the feat/platform-wallet-storage-rehydration branch, preserving existing feature lists.

Changes

Dependency branch tracking

Layer / File(s) Summary
Update Cargo dependency sources
Cargo.toml
dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage now track the shared feature branch instead of pinned revisions; existing features remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: lklimek

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the dependency update to track the platform PR branch for wallet-storage rehydration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/pin-platform-pr3968-branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lklimek
lklimek marked this pull request as ready for review July 28, 2026 11:51
@lklimek
lklimek enabled auto-merge (squash) July 28, 2026 11:51

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Cargo.toml (1)

23-23: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin the shared platform git dependencies to an immutable revision before release.

dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage still declare branch = "feat/platform-wallet-storage-rehydration" in Cargo.toml; while Cargo.lock currently resolves them to the same commit, cargo update can move those branch-pinned crates. Replace the branch references with a fixed rev pin once the upstream change is available, and keep releases locked with Cargo’s locked mode.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` at line 23, Update the shared platform dependencies dash-sdk,
rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage in
Cargo.toml to replace the feature branch reference with the upstream immutable
commit revision, preserving their existing features and dependency
configuration. Ensure Cargo.lock records the same revision so locked releases
remain reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Cargo.toml`:
- Line 23: Update the shared platform dependencies dash-sdk,
rs-sdk-trusted-context-provider, platform-wallet, and platform-wallet-storage in
Cargo.toml to replace the feature branch reference with the upstream immutable
commit revision, preserving their existing features and dependency
configuration. Ensure Cargo.lock records the same revision so locked releases
remain reproducible.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 26899aa8-ca7d-4b23-9433-3c0e6a672e01

📥 Commits

Reviewing files that changed from the base of the PR and between 86419a2 and 9f59d97.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

@lklimek
lklimek disabled auto-merge July 28, 2026 11:53
feat/platform-wallet-storage-rehydration moved 0ed8b4d1 -> debf67bd
since this branch was last synced.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@lklimek
lklimek enabled auto-merge (squash) July 28, 2026 11:56
@lklimek
lklimek merged commit 3e05d5f into v1.0-dev Jul 28, 2026
5 checks passed
@lklimek
lklimek deleted the chore/pin-platform-pr3968-branch branch July 28, 2026 12:09
orchardpaytl pushed a commit to orchardpaytl/orchardpay that referenced this pull request Jul 28, 2026
…ation (dashpay#940)

* chore(deps): track platform PR #3968 branch for wallet-storage rehydration

Switches dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, and
platform-wallet-storage from a pinned rev to branch tracking of
dashpay/platform#3968 (feat/platform-wallet-storage-rehydration), so
Cargo resolves its current HEAD instead of a fixed commit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* chore(deps): bump platform PR #3968 pin to latest branch HEAD

feat/platform-wallet-storage-rehydration moved 0ed8b4d1 -> debf67bd
since this branch was last synced.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
(cherry picked from commit 3e05d5f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants