forked from unslothai/unsloth
-
Notifications
You must be signed in to change notification settings - Fork 0
[staging] torch-index override (mirror of unslothai/unsloth#6692) #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielhanchen
wants to merge
10
commits into
cuda-override-base
Choose a base branch
from
cuda-torch-index-override
base: cuda-override-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
138c094
install: let UNSLOTH_TORCH_INDEX_FAMILY / _URL override CUDA wheel de…
danielhanchen b02a609
install: make the torch-index override authoritative across ROCm paths
danielhanchen 997155d
install: honor pinned torch index in CUDA/ROCm repair paths
danielhanchen 0c0e2cb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5d69193
Merge remote-tracking branch 'origin/main' into cuda-torch-index-over…
danielhanchen 5736d5d
install: honor torch-index override on the Windows installers too
danielhanchen 5a017ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d2d5f90
install: complete pinned-index handling for ROCm/Windows edge cases
danielhanchen 4a5baba
install: finish pinned ROCm/CUDA edge cases on Windows + repair path
danielhanchen f6c5e46
install: keep the ROCm to CPU fallback install inside the retry-helpe…
danielhanchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
.ToLowerInvariant()instead of.ToLower()to prevent potential locale-specific issues (such as the Turkish 'I' bug) when parsing the wheel index URL leaf. This also ensures consistency with the implementation ofGet-TorchIndexLeafinsetup.ps1.