Refactor and split nix integration tests into separate files#281
Open
Noi0103 wants to merge 1 commit into
Open
Refactor and split nix integration tests into separate files#281Noi0103 wants to merge 1 commit into
Noi0103 wants to merge 1 commit into
Conversation
lbeierlieb
requested changes
Jul 21, 2026
lbeierlieb
left a comment
lbeierlieb
left a comment
Contributor
There was a problem hiding this comment.
I really like the split, but the test utils should differentiate between "public API" and "internal helpers".
| @@ -0,0 +1,48 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
More usage of callPackage can make this file even cleaner, but we can leave that for a follow up.
Member
Author
There was a problem hiding this comment.
Yes, lets leave that for later. CallPackage adds some Attributes, so this is not a drop in replacement.
While working towards the file descriptor cli argument, writing a new test in the existing test landscape felt harder than it should. This refactor splits the different kinds of tests and gives individual control over the declared systemd configuration parts.
Noi0103
force-pushed
the
Noi0103/refactor-integration-tests
branch
from
July 21, 2026 11:27
ce3cb4b to
0c4c264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working towards the file descriptor cli argument, writing a new test in the existing test landscape felt harder than it should. This refactor splits the different kinds of tests and gives individual control over the declared systemd configuration parts.