wcurl: prevent silent overwrite with --output on older curl#99
Merged
Conversation
sergiodj
requested changes
May 1, 2026
sergiodj
left a comment
sergiodj
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
Minor nit regarding quotes in the error message, but otherwise this LGTM.
Updating error format based on suggestion Co-authored-by: Sergio Durigan Junior <github@sergiodj.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well this PR is a small one and just adds a defensive check to
exec_curl()to return an error when the user explicitly passes--outputalongside multiple URLs, but has a curl version older than7.83.0, but this is something that caused me too much frustration.In current scenatio what happens is when
--outputis explicitly provided, wcurl uses the identicalOUTPUT_PATHfor every single URL in the loop.On modern curl versions,
--no-clobbercorrectly prevents overwrites by appending numeric suffixes (.1,.2, etc.).However, wcurl project supports curl
7.46.0and higher.On versions prior to
7.83.0( based on change logs) , the--no-clobberflag is missing, causing multiple file downloads to silently overwrite the same local file sequentially.This throws a user-facing error to prevent silent data loss, and not leave them clueless