Skip to content

wcurl: fix missing argument crash for options #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergiodj merged 1 commit into from
May 1, 2026
Merged

wcurl: fix missing argument crash for options #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,5 +273,16 @@ testFragmentStripping()
assertContains "Verify whether 'wcurl' correctly strips #fragments from filenames" "${ret}" '--output document.pdf '
}

testMissingArgumentError()
{
ret=$(${WCURL_CMD} --curl-options 2>&1)
assertFalse "Verify whether 'wcurl' with missing argument exits with an error" "$?"
assertEquals "Verify whether 'wcurl' displays missing argument error for --curl-options" "${ret}" "Option '--curl-options' requires an argument."

ret=$(${WCURL_CMD} -o 2>&1)
assertFalse "Verify whether 'wcurl' with missing argument exits with an error" "$?"
assertEquals "Verify whether 'wcurl' displays missing argument error for -o" "${ret}" "Option '-o' requires an argument."
}

# shellcheck disable=SC1091
. shunit2
6 changes: 6 additions & 0 deletions wcurl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,9 @@ while [ -n "${1-}" ]; do
;;

--curl-options)
if [ -z "${2-}" ]; then
error "Option '${1}' requires an argument."
fi
shift
CURL_OPTIONS="${CURL_OPTIONS} ${1}"
;;
Expand All @@ -298,6 +301,9 @@ while [ -n "${1-}" ]; do
;;

-o | -O | --output)
if [ -z "${2-}" ]; then
error "Option '${1}' requires an argument."
fi
shift
HAS_USER_SET_OUTPUT="true"
OUTPUT_PATH="${1}"
Expand Down