build: bump setuptools from 83.0.0 to 84.0.0 in /requirements - #759
Conversation
|
|
2e62e2c to
a49a496
Compare
|
Done, both of them: -VENV_BOOTSTRAP ?= pip==26.2.1 setuptools==83.0.0 setuptools_scm[toml]==9.2.2 wheel==0.46.2
+VENV_BOOTSTRAP ?= pip==26.2.1 setuptools==84.0.0 setuptools_scm[toml]==9.2.2 wheel==0.46.2 # pip / setuptools version must match the version used in AWX venv (see README.md UPGRADE BLOCKERs)
- "${venv}/bin/python3" -m pip install -U 'pip==26.2.1' 'setuptools==83.0.0' pip-tools
+ "${venv}/bin/python3" -m pip install -U 'pip==26.2.1' 'setuptools==84.0.0' pip-toolsThose are the only two Also rebased onto current |
|
More conflicts thanks to #755 |
The venv bootstrap in the Makefile and the pip install in requirements/updater.sh pin setuptools of their own, so both move with the requirements pin rather than drifting behind it.
a49a496 to
b275d47
Compare
|
Rebased onto current -VENV_BOOTSTRAP ?= pip==26.2.1 setuptools==83.0.0 setuptools_scm[toml]==9.2.2 wheel==0.48.0
+VENV_BOOTSTRAP ?= pip==26.2.1 setuptools==84.0.0 setuptools_scm[toml]==9.2.2 wheel==0.48.0
|
SUMMARY
Bumps
setuptoolsfrom83.0.0to84.0.0inrequirements/requirements.txt. It is the build backend the image uses for every source distribution it installs.The Python requirements are outside Dependabot's scope on purpose: #675 turned on version updates for github-actions and for npm in
/awx/uiand left this file out, because it is compiled byrequirements/updater.shrather than hand-pinned. So this was produced the same waymake requirementsproduces it:run inside the
ascender_develimage, which is where that script insists on running. Pinned with==inrequirements.in, soupgradecannot move it: the pin is edited first andrunrecompiles against it. The result is 1 added / 1 removed in each of the two files.The
# CVE-2026-59890comment is deliberately kept on the pin. 83.0.0 is where that fix landed, so 84.0.0 stays above it and the reason for pinning still reads true; the comment would only be wrong if the pin ever moved down.Like the other build-toolchain bumps in this batch, the unit suite passing says less here than it does for a library: setuptools is exercised when the image builds a source distribution, not by the tests. The real check is a green image build, which happens once the workflow is approved on this fork pull request.
ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
Tests
Tested before opening, in the same image, with
setuptools 84.0.0installed into the AWX venv:CI does not run on pull requests from a fork until a maintainer approves the workflow, so this is what stands behind the change until then.