build: bump django-pglocks from 1.0.4 to 2.1.0 in /requirements - #728
Open
blaipr wants to merge 1 commit into
Open
build: bump django-pglocks from 1.0.4 to 2.1.0 in /requirements#728blaipr wants to merge 1 commit into
blaipr wants to merge 1 commit into
Conversation
Compiled with requirements/updater.sh upgrade django-pglocks in the ascender_devel image. 2.1.0 moved its backend handling into a new package, django-pgware, so the lockfile gains a dependency as well as a version, and licenses/django-pgware.txt comes with it: test_python_and_js_licenses fails without it. This one is only ever exercised on PostgreSQL. awx/main/utils/pglock.py short circuits to a no-op when connection.vendor is not postgresql, so the SQLite suite never reaches the library at all; it was tested against a real PostgreSQL as well.
blaipr
force-pushed
the
build/bump-django-pglocks-2.1.0-requirements
branch
from
August 26, 2026 11:50
a56a565 to
f07c019
Compare
Contributor
Author
|
Rebased onto current The change itself is unchanged: |
Contributor
|
This package is deprecated and the newest version you are upgrading to is just a shim for the new django-pgware package you imported. So its best just to move to the new one. https://github.com/Xof/django-pglocks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bumps
django-pglocksfrom1.0.4to2.1.0inrequirements/requirements.txt. It provides the advisory locksawx/main/utils/pglock.pywraps, which the task manager and the dispatcher take to serialise work across nodes.Two things come with it:
django-pgware1.0.0, a new dependency. 2.1.0 moved its backend handling into that package, so this bump adds a line rather than only changing one.licenses/django-pgware.txt, its PostgreSQL License text. Any new package needs one, ortest_licenses.py::test_python_and_js_licensesfails withlicense for requirement django-pgware is missing.The Python requirements are outside Dependabot's scope on purpose: #675 turned on version updates for github-actions and for npm in
/awx/uiand left this file out, because it is compiled byrequirements/updater.shrather than hand-pinned. So it was produced the same waymake requirementsproduces it:run inside the
ascender_develimage.ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
Tests
I tested this update before opening the pull request; it is not a resolver-only change.
On a real PostgreSQL, because nothing else exercises it.
awx/main/utils/pglock.pyshort circuits toyield Truewheneverconnection.vendoris notpostgresql, so a green SQLite suite says nothing about this library. Against a PostgreSQL 15 container, with the settingsmake test-postgresuses:And a direct exercise of the wrapper across two sessions, which is the behaviour that matters here:
Identical on 1.0.4 and on 2.1.0, so the semantics AWX relies on are unchanged.
The rest of the suite, on a freshly created database:
That failure is not this bump.
test_proxy_ip_allowedpatchesREMOTE_HOST_HEADERSandPROXY_IP_ALLOWED_LISTon the settings singleton and intermittently sees another worker's state under-n auto; it passes solo here (7 passed), and I have now seen it fail three times today across unrelated bumps. The serial baseline for this tree is 3816 passed, 10 skipped, with nothing failing.Before the license file was added, the same run reported
test_python_and_js_licensesfailing, which is what that test is for.CI does not run on pull requests from a fork until a maintainer approves the workflow, so this is what stands behind the change until then.