revert disk size to 31G and add workaround for download pods disk usuage.#1246
revert disk size to 31G and add workaround for download pods disk usuage.#1246praveenkumar wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
praveenkumar
force-pushed
the
fix_disk_size
branch
from
bc2748b to
8c9a364
Compare
| # Remove the downloads pods because of https://redhat.atlassian.net/browse/OCPBUGS-88450 | ||
| # as workaround | ||
| retry ${OC} delete pod -n openshift-console -l app=console,component=downloads | ||
| retry ${OC} wait --for=condition=Ready pod -n openshift-console -l app=console,component=downloads --timeout=60s |
There was a problem hiding this comment.
Why do we do it twice? After the VM is installed/running with crc, will these pods be recreated and fill again the disk?
There was a problem hiding this comment.
here we are doing twice because it is observed that as part of MCO change when node reboot it sometime again have those download pod restarted hence we are doing it twice just to make sure it doesn't fill the disk.
After the VM is installed/running with crc, will these pods be recreated
Bundles are created after removing every pod/container so with crc those container come up cleanly without filling the disk space until user manually restart that download pod.
There was a problem hiding this comment.
until user manually restart that download pod.
but these download pods are not auto-created/auto-started, they would have to be explicitly started by the user? If that’s correct, then ack from me.
Looks like it was happening because of https://redhat.atlassian.net/browse/OCPBUGS-88450 one This reverts commit ba3ba79.
praveenkumar
force-pushed
the
fix_disk_size
branch
from
8c9a364 to
c908f56
Compare
|
/test e2e-test |
|
/test e2e-snc |
|
/retest |
1 similar comment
|
/retest |
|
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
No description provided.