Skip to content

Test: update the image to rhel-10 to test 9p kernel module#1235

Open
praveenkumar wants to merge 1 commit into
crc-org:release-4.21from
praveenkumar:rhel_10
Open

Test: update the image to rhel-10 to test 9p kernel module#1235
praveenkumar wants to merge 1 commit into
crc-org:release-4.21from
praveenkumar:rhel_10

Conversation

@praveenkumar

@praveenkumar praveenkumar commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Updated image stream selection to ensure the correct RHCOS image is used when setting up cluster configurations, excluding OKD installations.

@openshift-ci openshift-ci Bot requested review from anjannath and cfergeau June 1, 2026 07:54
@openshift-ci

openshift-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anjannath for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 23b610ca-1d65-4383-9f36-49da1b8bf6dc

📥 Commits

Reviewing files that changed from the base of the PR and between a07769b and 1deaf5a.

📒 Files selected for processing (1)
  • snc.sh

Walkthrough

The change updates the RHCOS image stream identifier used by the SNC build script. When BUNDLE_TYPE is not okd, the script now selects the rhel-coreos-10 image stream instead of rhel-coreos for the RHCOS image lookup.

Changes

RHCOS Image Stream Update

Layer / File(s) Summary
RHCOS image stream selection
snc.sh
Non-OKD builds now use the rhel-coreos-10 image stream for RHCOS image selection instead of rhel-coreos; OKD branch remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A tiny tweak, a stream renamed,
From rhel-coreos came 10's claim,
One line changed, the build now flows,
To newer pastures RHCOS goes,
🐰 hops onward, change complete!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the RHCOS image stream from rhel-coreos to rhel-coreos-10 for non-OKD bundle types to test 9p kernel module compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@praveenkumar

Copy link
Copy Markdown
Member Author

/hold

This is only for testing so no need to merge.

@redbeam

redbeam commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

/retest

2 similar comments
@praveenkumar

Copy link
Copy Markdown
Member Author

/retest

@praveenkumar

Copy link
Copy Markdown
Member Author

/retest

@praveenkumar

Copy link
Copy Markdown
Member Author

last time it failed because of following

 podman run --rm -v /home/core/packages:/packages:Z quay.io/centos/centos:stream9 sh -c 'dnf install -y createrepo && createrepo /packages'
Trying to pull quay.io/centos/centos:stream9...
Getting image source signatures
Copying blob sha256:672701048af7015401b62208844d1f5f327e6ad260c352c57e9919109781d105
Copying config sha256:003d02fd29b3a6e0fa512dec9fc88c3c3578d1b7732c4d8d4a0457adb265d730
Writing manifest to image destination
CentOS Stream 9 - BaseOS                        0.0  B/s |   0  B     04:00    
Errors during downloading metadata for repository 'baseos':
  - Curl error (6): Couldn't resolve host name for https://mirrors.centos.org/metalink?repo=centos-baseos-9-stream&arch=x86_64&protocol=https,http [Could not resolve host: mirrors.centos.org]
Error: Failed to download metadata for repo 'baseos': Cannot prepare internal mirrorlist: Curl error (6): Couldn't resolve host name for https://mirrors.centos.org/metalink?repo=centos-baseos-9-stream&arch=x86_64&protocol=https,http [Could not resolve host: mirrors.centos.org]
+ podman rmi quay.io/centos/centos:stream9
Untagged: quay.io/centos/centos:stream9
Deleted: 003d02fd29b3a6e0fa512dec9fc88c3c3578d1b7732c4d8d4a0457adb265d730
+ ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i id_ecdsa_crc core@192.168.126.11 'sudo bash -c '\''cat > /etc/yum.repos.d/local.repo << EOF
[local]
name=Local repo
baseurl=file:///home/core/packages/
enabled=1
gpgcheck=0
EOF'\'''

@praveenkumar

Copy link
Copy Markdown
Member Author

not sure why on the CI it is failing but locally it is working as expected.

$ podman run --rm quay.io/centos/centos:stream9 sh -c 'dnf install -y createrepo'
CentOS Stream 9 - BaseOS                        679 kB/s | 8.9 MB     00:13    
CentOS Stream 9 - AppStream                     4.9 MB/s |  28 MB     00:05    
CentOS Stream 9 - Extras packages               9.0 kB/s |  21 kB     00:02    
Dependencies resolved.
================================================================================
 Package                 Architecture Version             Repository       Size
================================================================================
Installing:
 createrepo_c            x86_64       0.20.1-4.el9        appstream        74 k
Installing dependencies:
 createrepo_c-libs       x86_64       0.20.1-4.el9        appstream        98 k

Transaction Summary
================================================================================
Install  2 Packages

Total download size: 172 k
Installed size: 446 k
Downloading Packages:
(1/2): createrepo_c-0.20.1-4.el9.x86_64.rpm      26 kB/s |  74 kB     00:02    
(2/2): createrepo_c-libs-0.20.1-4.el9.x86_64.rp  35 kB/s |  98 kB     00:02    
--------------------------------------------------------------------------------
Total                                            52 kB/s | 172 kB     00:03     
CentOS Stream 9 - AppStream                     1.6 MB/s | 1.6 kB     00:00    
Importing GPG key 0x8483C65D:
 Userid     : "CentOS (CentOS Official Signing Key) <security@centos.org>"
 Fingerprint: 99DB 70FA E1D7 CE22 7FB6 4882 05B5 55B3 8483 C65D
 From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial
Key imported successfully
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                        1/1 
  Installing       : createrepo_c-libs-0.20.1-4.el9.x86_64                  1/2 
  Installing       : createrepo_c-0.20.1-4.el9.x86_64                       2/2 
  Running scriptlet: createrepo_c-0.20.1-4.el9.x86_64                       2/2 
  Verifying        : createrepo_c-0.20.1-4.el9.x86_64                       1/2 
  Verifying        : createrepo_c-libs-0.20.1-4.el9.x86_64                  2/2 

Installed:
  createrepo_c-0.20.1-4.el9.x86_64     createrepo_c-libs-0.20.1-4.el9.x86_64    

@praveenkumar

Copy link
Copy Markdown
Member Author

/retest

@praveenkumar

Copy link
Copy Markdown
Member Author

So I tried locally to reproduce the error but it is not reproduced :( , able to provision the system

$ ssh -i id_ecdsa_crc core@192.168.126.11
The authenticity of host '192.168.126.11 (192.168.126.11)' can't be established.
ED25519 key fingerprint is SHA256:YUMHDfboouTBN4QLn5atytizGxzxxnDTz9P6pPX3Kt4.
This key is not known by any other names.
Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
Warning: Permanently added '192.168.126.11' (ED25519) to the list of known hosts.
Red Hat Enterprise Linux CoreOS 10.2.20260521-0
  Part of OpenShift 4.21, RHCOS is a Kubernetes-native operating system
  managed by the Machine Config Operator (`clusteroperator/machine-config`).

WARNING: Direct SSH access to machines is not recommended; instead,
make configuration changes via `machineconfig` objects:
  https://docs.openshift.com/container-platform/4.21/architecture/architecture-rhcos.html

@praveenkumar

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 1deaf5a link true /test e2e-snc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@redbeam

redbeam commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@redbeam

redbeam commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/retest

@redbeam

redbeam commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@praveenkumar can you rebase this? We can give it another try now and see if the pipeline passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants