gtk.cfg: Remove pure annotation from g_str_has_prefix/suffix - #8788
Open
correctmost wants to merge 1 commit into
Open
gtk.cfg: Remove pure annotation from g_str_has_prefix/suffix#8788correctmost wants to merge 1 commit into
correctmost wants to merge 1 commit into
Conversation
g_str_has_prefix and g_str_has_suffix are not technically pure because they can log to the console if a precondition fails. This partially reverts commit 7cc7c0b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g_str_has_prefixandg_str_has_suffixare not technically pure because they can log to the console if a precondition fails.This partially reverts commit 7cc7c0b.
Some notes:
The original
gtk.cfgchange hasn't been released yet, so the revert shouldn't cause any churn for users.GLib has code like this:
Most real-world code is treating this function as safe to call inside of an assert, even though it could technically have side effects if one of the preconditions fails.
I removed the pure annotation to err on the side of correctness and pedantry, even though most projects would view the warnings as "false positives" from a practical perspective.
Here is example usage from QEMU: