Skip to content

NO-JIRA: denylist: disable fips.enable.tls for c9s/c10s - #211

Merged
openshift-merge-bot[bot] merged 1 commit into
coreos:mainfrom
HuijingHei:disable-fips-tls-cs
Mar 24, 2026
Merged

NO-JIRA: denylist: disable fips.enable.tls for c9s/c10s#211
openshift-merge-bot[bot] merged 1 commit into
coreos:mainfrom
HuijingHei:disable-fips-tls-cs

Conversation

@HuijingHei

Copy link
Copy Markdown
Contributor

See #204

@openshift-ci-robot

Copy link
Copy Markdown

@HuijingHei: This pull request explicitly references no jira issue.

Details

In response to this:

See #204

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the kola-denylist.yaml file to disable the fips.enable.tls test for CentOS Stream 9 (c9s) and CentOS Stream 10 (c10s). The change is a straightforward addition to an existing denylist entry and appears correct, following the established format for disabling failing tests on specific streams. No issues were found in this change.

@angelcerveraroldan angelcerveraroldan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbtrystram

Copy link
Copy Markdown
Member

Let's update the egress rules to allow that connection rather than denylisting the test.

@dustymabe

Copy link
Copy Markdown
Member

Let's update the egress rules to allow that connection rather than denylisting the test.

some discussion for strategy/implementation of the test over in coreos/coreos-assembler#4477 (comment)

@dustymabe

Copy link
Copy Markdown
Member

while we discuss this test further in coreos/coreos-assembler#4477 lets merge this for now.

/lgtm

@openshift-ci

openshift-ci Bot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: angelcerveraroldan, dustymabe, HuijingHei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,angelcerveraroldan,dustymabe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 13ccd07 into coreos:main Mar 24, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants