NO-JIRA: denylist: disable fips.enable.tls for c9s/c10s - #211
Conversation
|
@HuijingHei: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Code Review
This pull request updates the kola-denylist.yaml file to disable the fips.enable.tls test for CentOS Stream 9 (c9s) and CentOS Stream 10 (c10s). The change is a straightforward addition to an existing denylist entry and appears correct, following the established format for disabling failing tests on specific streams. No issues were found in this change.
|
Let's update the egress rules to allow that connection rather than denylisting the test. |
some discussion for strategy/implementation of the test over in coreos/coreos-assembler#4477 (comment) |
|
while we discuss this test further in coreos/coreos-assembler#4477 lets merge this for now. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: angelcerveraroldan, dustymabe, HuijingHei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See #204