Skip to content

Sync repo templates ⚙#1263

Merged
Rolv-Apneseth merged 1 commit into
coreos:mainfrom
coreosbot-releng:repo-templates
Jul 16, 2026
Merged

Sync repo templates ⚙#1263
Rolv-Apneseth merged 1 commit into
coreos:mainfrom
coreosbot-releng:repo-templates

Conversation

@coreosbot-releng

@coreosbot-releng coreosbot-releng commented Mar 16, 2026

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by a workflow, syncs repository templates. The change in .copr/Makefile incorrectly removes a command to download a source file required for the COPR build. This will cause the build to fail. I have left a comment on the removed line explaining why it should be restored.

Comment thread .copr/Makefile
# similar to https://github.com/actions/checkout/issues/760, but for COPR
git config --global --add safe.directory '*'
curl -LOf https://src.fedoraproject.org/rpms/rust-afterburn/raw/rawhide/f/rust-afterburn.spec
curl -LOf https://src.fedoraproject.org/rpms/rust-afterburn/raw/rawhide/f/90-afterburn-authorized-keys-file.conf

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This line should not have been removed. It downloads 90-afterburn-authorized-keys-file.conf, which is a source file required by rust-afterburn.spec. The spec file is downloaded from Fedora Rawhide in the preceding line and lists this file as Source1. Removing this curl command will cause the rpmbuild step to fail because the source file will be missing.

@travier

travier commented May 20, 2026

Copy link
Copy Markdown
Member

The change from #1262 should be reflected in the templates repo.

@Rolv-Apneseth

Copy link
Copy Markdown
Member

@Rolv-Apneseth Rolv-Apneseth added the skip-notes This PR does not need release notes label Jul 16, 2026

@Rolv-Apneseth Rolv-Apneseth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rolv-Apneseth Rolv-Apneseth enabled auto-merge July 16, 2026 14:16
@Rolv-Apneseth Rolv-Apneseth merged commit 2b86655 into coreos:main Jul 16, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-notes This PR does not need release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants