Skip to content

harden: use bounded strlcpy/snprintf in example_app.c... #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: openwrt-25.12
Choose a base branch
from
Open

harden: use bounded strlcpy/snprintf in example_app.c... #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions applications/luci-app-oled/src/Example_Code/example_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ char *get_ip_addr(char *ifname) {
// Type of address to retrieve - IPv4 IP address
ifr.ifr_addr.sa_family = AF_INET;
// Copy the interface name in the ifreq structure
strncpy(ifr.ifr_name, ifname, IFNAMSIZ - 1);
snprintf(ifr.ifr_name, IFNAMSIZ, "%s", ifname);
ioctl(n, SIOCGIFADDR, &ifr);
close(n);
return inet_ntoa(((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr);
Expand Down Expand Up @@ -503,12 +503,12 @@ void testnetspeed(int mode, int y, unsigned long int rx, unsigned long int tx) {
switch (mode) {
case SPLIT:
setTextSize(2);
strcpy(buf, tx_str);
snprintf(buf, sizeof(buf), "%s", tx_str);
setCursor((127 - (strlen(buf) + 1) * 11) / 2, 0);
oled_write(24);
print_str(buf);

strcpy(buf, rx_str);
snprintf(buf, sizeof(buf), "%s", rx_str);
setCursor((127 - (strlen(buf) + 1) * 11) / 2, 16);
oled_write(25);
print_str(buf);
Expand Down