fix: the dns resolver function uses a fixed-size buf... in rrdns.c - #410
Open
anupamme wants to merge 1 commit into
Open
Conversation
The DNS resolver function uses a fixed-size buffer to read lines from /etc/resolv Signed-off-by: anupamme <mediratta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address critical severity security finding in
libs/rpcd-mod-rrdns/src/rrdns.c.Vulnerability
V-001libs/rpcd-mod-rrdns/src/rrdns.c:260Description: The DNS resolver function uses a fixed-size buffer to read lines from /etc/resolv.conf without validation. An attacker controlling this file can craft long hostnames that overflow the buffer, potentially corrupting adjacent memory.
Evidence
Exploitation scenario: Local attacker with write access to /etc/resolv.conf (via privilege escalation or container escape) crafts a nameserver entry exceeding 64 bytes.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
libs/rpcd-mod-rrdns/src/rrdns.cBehavior Preservation
The change is scoped to 1 file on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
This change addresses a pattern flagged by static analysis. The code path handles user-influenced input and the fix reduces the attack surface against both manual and automated exploitation.
Automated security fix by OrbisAI Security