fix: ask for current password in password reset flow - #4116
Open
gtmdev-br wants to merge 1 commit into
Open
Conversation
- Add current password field to the password reset form - Validate current password is provided before allowing reset - Handle 'not-authorized' error from server when current password is incorrect - Add test for incorrect current password scenario Closes conversejs#3120
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const jid = _converse.session.get('jid'); | ||
| const domain = _converse.session.get('domain'); | ||
| const connection = api.connection.get(); |
| const jid = _converse.session.get('jid'); | ||
| const domain = _converse.session.get('domain'); | ||
| const connection = api.connection.get(); | ||
| const bare_jid = Strophe.getBareJidFromJid(jid); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a current password field to the password reset form, as requested in #3120. The change ensures that users must provide their current password before being allowed to reset it, preventing unauthorized password changes by someone with access to the browser.
Changes
Template (
src/plugins/profile/templates/password-reset.js):autocomplete="current-password"attributeComponent (
src/plugins/profile/password-reset.js):current_password_errorstate propertynot-authorizederror from XMPP server when current password is incorrectTests (
src/plugins/profile/tests/password-reset.js):submitPasswordResetFormhelper to include current passwordTesting
All 4 password reset tests pass:
Closes #3120