Fix intermittent missing new message count badge (Issue #4110) - #4111
Open
abhiramvsmg wants to merge 2 commits into
Open
Fix intermittent missing new message count badge (Issue #4110)#4111abhiramvsmg wants to merge 2 commits into
abhiramvsmg wants to merge 2 commits into
Conversation
jcbrand
requested changes
Aug 12, 2026
|
|
||
| if (contact) { | ||
| this.contact = contact; | ||
| this.updateContactUnreadCounter(); |
Member
There was a problem hiding this comment.
Further down in this if statement the contact:add event is triggered and the ModelWithContact model already listens for that event and then calls updateContactUnreadCounter().
So this change here look unnecessary.
Also, the test passes without this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a timing race condition where the roster badge fails to update with new unread messages if they arrive before the linked roster contact object has finished loading asynchronously.
Changes :
Fix : Added a call to
this.updateContactUnreadCounter()insidesetModelContactinsrc/headless/shared/model-with-contact.jsto sync the unread counter as soon as the contact resolves.Test : Added a regression integration test in
src/headless/plugins/chat/tests/chat.jsthat mock-delays the contact load, sets the unread count, and asserts that the contact's unread badge synchronizes correctly upon resolution.Changelog : Added an entry for Issue #4110 in
CHANGES.md.