Feature: Allow pinning conversations to the top (XEP-0469) - #3949
Feature: Allow pinning conversations to the top (XEP-0469)#3949mercihabam wants to merge 3 commits into
Conversation
|
Before adding tests for the many changes, I would appreciate a review from the maintainers. Thanks for taking the time to look into this! |
|
I went ahead and added tests for the changes. Please review this when you get a chance. Thanks! |
|
@jcbrand could you please take a look at this when you get the chance? Thanks. |
|
@mercihabam Please rebase your PR onto the latest master branch. |
5dcb28f to
c206ce6
Compare
|
@jcbrand that is now done. |
|
@jcbrand don't forget this one please. 😊 |
|
I won't forget, but I'm first finishing off the emoji reactions and popular emojis work. Then I'll make a new release and then I'll get back to all the outstanding PRs. |
|
@mercihabam There is a failing test which looks like it might be related to your changes: Please also squash your commits into one and rebase onto the latest |
c206ce6 to
c7759a5
Compare
I did not see that one because some tests are skipped on my instance; I'm still figuring out why. But now I have fixed that, rebased onto master, and squashed the commits. Thanks! |
jcbrand
left a comment
There was a problem hiding this comment.
Thanks @mercihabam, please see my review comments.
298032b to
702c27a
Compare
… truth - adjusting as well how UI update on state changes
|
@jcbrand I have refactored this as discussed. A few tests are now failing, but I will fix them soon. Thanks! |
|
Closed in favor of #4088 |
This is an implementation of #3509, which allows users to pin bookmarked MUC rooms to the top.
Here is a quick overview of how it looks:


