Skip to content

Feature: Allow pinning conversations to the top (XEP-0469) - #3949

Closed
mercihabam wants to merge 3 commits into
conversejs:masterfrom
mercihabam:bookmark-pinning
Closed

Feature: Allow pinning conversations to the top (XEP-0469)#3949
mercihabam wants to merge 3 commits into
conversejs:masterfrom
mercihabam:bookmark-pinning

Conversation

@mercihabam

@mercihabam mercihabam commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

This is an implementation of #3509, which allows users to pin bookmarked MUC rooms to the top.

Here is a quick overview of how it looks:
Screenshot 2026-03-14 at 15 34 08
Screenshot 2026-03-14 at 15 34 33
Screenshot 2026-03-14 at 15 34 48

@mercihabam

Copy link
Copy Markdown
Contributor Author

Before adding tests for the many changes, I would appreciate a review from the maintainers. Thanks for taking the time to look into this!

@mercihabam
mercihabam marked this pull request as ready for review March 5, 2026 14:36
@mercihabam

Copy link
Copy Markdown
Contributor Author

I went ahead and added tests for the changes. Please review this when you get a chance. Thanks!

@mercihabam

Copy link
Copy Markdown
Contributor Author

@jcbrand could you please take a look at this when you get the chance? Thanks.

@jcbrand

jcbrand commented Apr 9, 2026

Copy link
Copy Markdown
Member

@mercihabam Please rebase your PR onto the latest master branch.

@mercihabam

Copy link
Copy Markdown
Contributor Author

@jcbrand that is now done.

@mercihabam

Copy link
Copy Markdown
Contributor Author

@jcbrand don't forget this one please. 😊

@jcbrand

jcbrand commented Apr 24, 2026

Copy link
Copy Markdown
Member

I won't forget, but I'm first finishing off the emoji reactions and popular emojis work. Then I'll make a new release and then I'll get back to all the outstanding PRs.

@jcbrand

jcbrand commented May 5, 2026

Copy link
Copy Markdown
Member

@mercihabam There is a failing test which looks like it might be related to your changes:

Chrome 147.0.0.0 (Linux 0.0.0) A MUC domain group is collapsible FAILED
	Expected true to be falsy.
	    at <Jasmine>
	    at src/plugins/roomslist/tests/grouplists.js:118:52
	    at async UserContext.<anonymous> (src/headless/tests/mock.js:625:13)
Chrome 147.0.0.0 (Linux 0.0.0): Executed 479 of 625 (1 FAILED) (0 secs / 46.029 secs)
Chrome 147.0.0.0 (Linux 0.0.0) A MUC domain group is collapsible FAILED
	Expected true to be falsy.
	    at <Jasmine>
	    at src/plugins/roomslist/tests/grouplists.js:118:52
	    at async UserContext.<anonymous> (src/headless/tests/mock.js:625:13)

Please also squash your commits into one and rebase onto the latest master branch.

@mercihabam

Copy link
Copy Markdown
Contributor Author

@mercihabam There is a failing test which looks like it might be related to your changes:

I did not see that one because some tests are skipped on my instance; I'm still figuring out why. But now I have fixed that, rebased onto master, and squashed the commits. Thanks!

@jcbrand jcbrand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mercihabam, please see my review comments.

Comment thread src/plugins/bookmark-views/components/templates/pin-list.js Outdated
Comment thread src/headless/plugins/bookmarks/tests/bookmarks.js Outdated
Comment thread src/headless/plugins/bookmarks/collection.js Outdated
Comment thread src/plugins/bookmark-views/components/bookmarks-pin-list.js Outdated
Comment thread src/plugins/bookmark-views/components/model.js Outdated
Comment thread src/plugins/controlbox/templates/controlbox.js Outdated
Comment thread src/plugins/bookmark-views/components/bookmarks-pin-list.js Outdated
Comment thread src/plugins/roomslist/view.js Outdated
Comment thread src/headless/plugins/bookmarks/collection.js Outdated
@mercihabam
mercihabam requested a review from jcbrand May 19, 2026 22:12
… truth - adjusting as well how UI update on state changes
@mercihabam
mercihabam marked this pull request as draft May 20, 2026 20:36
@mercihabam

Copy link
Copy Markdown
Contributor Author

@jcbrand I have refactored this as discussed. A few tests are now failing, but I will fix them soon. Thanks!

@mercihabam
mercihabam marked this pull request as ready for review May 21, 2026 11:19
@jcbrand

jcbrand commented Jun 18, 2026

Copy link
Copy Markdown
Member

Closed in favor of #4088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants