Skip to content

Upgrade to Biome v2 - #1790

Open
ajeetdsouza wants to merge 4 commits into
mainfrom
ajeet/biome
Open

Upgrade to Biome v2#1790
ajeetdsouza wants to merge 4 commits into
mainfrom
ajeet/biome

Conversation

@ajeetdsouza

Copy link
Copy Markdown
Contributor

This PR gets rid of all the package-specific configs we had set up for formatting, in favor of a unified config file spanning the entire workspace. This is also the approach favored by Biome v2.

Signed-off-by: Ajeet D'Souza <98ajeet@gmail.com>
Signed-off-by: Ajeet D'Souza <98ajeet@gmail.com>
Signed-off-by: Ajeet D'Souza <98ajeet@gmail.com>
@timostamm

Copy link
Copy Markdown
Member

As discussed in person, biome's favored approach doesn't necessarily match turborepo's favored approach, so the decisions to make isn't clearly cut.

Getting rid of boilerplate config is obviously a win, but no longer being able to use turbo as the single interface for build tasks including package scoping is a loss.

It's a trade-off, and it would be very useful to be able to understand the trade-off and rationale from the PR. If the decision is to keep all formatting and linting in root tasks, please make sure to update CONTRIBUTING.md to reflect that.

Please check how this approach translates to other repositories using biome. For example, if a package level task depends on lint or - more likely - format, I'm not sure running a root level format instead is a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants