Skip to content

arrow: fix turning simd off #27906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dvirtz wants to merge 3 commits into from
Closed

arrow: fix turning simd off #27906

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
850b7ab
arrow: fix turning simd off
dvirtz Jul 10, 2025
01243f5
apply review suggestions
dvirtz Jul 11, 2025
1df4156
disable invalid ARM64/MSVC system
dvirtz Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions recipes/arrow/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ class ArrowConan(ConanFile):
"filesystem_layer": [True, False],
"hdfs_bridgs": [True, False],
"plasma": [True, False, "deprecated"],
"simd_level": [None, "default", "sse4_2", "avx2", "avx512", "neon", ],
"runtime_simd_level": [None, "sse4_2", "avx2", "avx512", "max"],
"simd_level": ["default", "sse4_2", "avx2", "avx512", "neon", "none"],
"runtime_simd_level": ["sse4_2", "avx2", "avx512", "max", "none"],
"with_backtrace": [True, False],
"with_boost": ["auto", True, False],
"with_csv": [True, False],
Expand Down Expand Up @@ -185,8 +185,8 @@ def requirements(self):
self.requires("lz4/1.9.4")
if self.options.with_snappy:
self.requires("snappy/1.1.9")
if self.options.get_safe("simd_level") != None or \
self.options.get_safe("runtime_simd_level") != None:
if self.options.simd_level != "none" or \
self.options.runtime_simd_level != "none":
self.requires("xsimd/13.0.0")
if self.options.with_zlib:
self.requires("zlib/[>=1.2.11 <2]")
Expand Down Expand Up @@ -252,6 +252,9 @@ def validate(self):

if self.options.parquet and not self.options.with_thrift:
raise ConanInvalidConfiguration("arrow:parquet requires arrow:with_thrift")

if self.settings.arch in ["armv8", "armv8.3"] and is_msvc(self):
raise ConanInvalidConfiguration("arrow does not support ARM64 with MSVC compiler")

def build_requirements(self):
if Version(self.version) >= "20.0.0":
Expand Down Expand Up @@ -536,7 +539,8 @@ def package_info(self):
self.cpp_info.components["libarrow"].requires.append("lz4::lz4")
if self.options.with_snappy:
self.cpp_info.components["libarrow"].requires.append("snappy::snappy")
if self.options.get_safe("simd_level") != None or self.options.get_safe("runtime_simd_level") != None:
if self.options.simd_level != "none" or \
self.options.runtime_simd_level != "none":
self.cpp_info.components["libarrow"].requires.append("xsimd::xsimd")
if self.options.with_zlib:
self.cpp_info.components["libarrow"].requires.append("zlib::zlib")
Expand Down