Add librhash/1.3.8 by madebr · Pull Request #277 · conan-io/conan-center-index

madebr · 2019-11-02T01:37:28Z

Specify library name and version: librhash/1.3.8

Tested on Linux 32- and 64-bit

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2019-11-02T01:43:16Z

Some configurations of 'librhash/1.3.8' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: librhash:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [PACKAGE LICENSE (KB-H012)] No 'licenses' folder found in package: /tmp/c3ipr/pr_277_1_0_0/.conan/data/librhash/1.3.8/_/_/package/b34df74c5d19404b38553e37011cc9839b6cc02c (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H012)
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2019-11-02T02:52:31Z

Some configurations of 'librhash/1.3.8' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: librhash:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: librhash:shared-False
Access to all the logs

conan-center-bot · 2019-11-02T19:38:30Z

Some configurations of 'librhash/1.3.8' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: librhash:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2019-11-02T20:18:21Z

All green! 😊

librhash/1.3.8: Generated 78 packages. All logs here

conan-center-bot · 2019-11-02T20:23:47Z

All green! 😊

librhash/1.3.8: Generated 78 packages. All logs here

danimtb · 2019-11-04T08:38:07Z

Why this migration to a custom CMake file to build this library? Shouldn't we add a comment here about it? Would users be concerned of this change as something critical?

librhash provides a configure script that works fine on Linux.
For Visual Studio, it provides a vcxproj file, that does enable setting the Visual Studio compiler runtime or shared/static library option.
The vcxproj itself looks very generic.

If this library doesn't support visual studio or doesn't support shared or specific runtime, I would make those configurations as invalid instead of creating a new CMake file for it. Completely changing the build system to a library is a major change IMO

Still think this is a very important change. @SSE4 @uilianries WDYT?

I investigated librhash yesterday, the project is simple in terms of build. I don't like keeping a custom cmake file here if we can invoke autotools and msbuild, so I would prefer dropping any invalid configuration, if we can't use MSBuild. However, I opened a PR to author (rhash/RHash#103), offering CMake support, which can be used by any user, including in our recipes. In summary, use autotools and msbuild for now.

ping @madebr

@uilianries There is already a cmake pr rhash/RHash#71
I don't see them accepting a pr in the near future.

conan-center-bot · 2019-11-04T17:46:35Z

All green! 😊

librhash/1.3.8: Generated 78 packages. All logs here

uilianries · 2019-11-12T19:42:01Z

I'm not confident using this part for a generic recipe, it may change on a next version. You can try something similar what vcpkg did: https://github.com/microsoft/vcpkg/blob/master/ports/rhash/CMakeLists.txt They extract the source file list from the Makefile

I think vcpkg is wrong here because it is extracting the SOURCES variable where I think it should extract LIBRHASH_FILES.
The files in the SOURCES variable are for the rhash executable.
I changed it into something similar but I do the parsing in the conanfile.py recipe because the regex would become too complicated (files are spread over multiple lines).

I checked rhash/RHash#71, where they also make the distinction between files in the root folder and files in the librhash subfolder.

At the moment, I am passing the sources as an argument to the cmake file during configuration.
Would this be fine? Generating a CMakeLists.txt during source() that contains the sources and add that file to the recipe. Or would you generate this cmake file during the build step? Or is the current approach fine?

conan-center-bot · 2019-11-16T00:01:28Z

All green! 😊

librhash/1.3.8: Generated 78 packages. All logs here

conan-center-bot · 2019-11-27T14:17:00Z

All green! 😊

librhash/1.3.8: Generated 78 packages. All logs here

conan-center-bot · 2019-11-27T14:37:30Z

All green! 😊

librhash/1.3.8: Generated 78 packages. All logs here

conan-center-bot · 2019-11-27T14:42:54Z

All green! 😊

librhash/1.3.8: Generated 78 packages. All logs here

conan-center-bot · 2019-12-20T08:55:32Z

All green! 😊

librhash/1.3.8: Generated 82 packages. All logs here

conan-center-bot · 2020-01-11T01:09:16Z

Some configurations of 'librhash/1.3.9' failed in build 12 (c558869ba84a940842b0dd6d7f67a51d6b57861a):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: librhash:shared-False
Access to all the logs

conan-center-bot · 2020-01-15T16:51:28Z

Some configurations of 'librhash/1.3.9' failed in build 13 (c558869ba84a940842b0dd6d7f67a51d6b57861a):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: librhash:shared-False
Access to all the logs

conan-center-bot · 2020-01-25T10:40:10Z

Some configurations of 'librhash/1.3.9' failed in build 14 (6eeb1efcf32bcbbe047a240eb54a4e77235e40e1):

Linux x86_64, Release, gcc 5, libstdc++ . Options: librhash:shared-True
Access to all the logs

conan-center-bot · 2020-01-25T11:43:19Z

All green in build 15 (afb731cb0dd3614a0101737f4e228c2557bd7f7e)! 😊

librhash/1.3.9: Generated 64 packages. All logs here

SSE4 · 2020-01-28T17:10:45Z

@uilianries I think it should be good now (all comments were addressed) - let's move forward this one

conan-center-bot added the Failed label Nov 2, 2019

madebr force-pushed the librhash branch from b866f4b to 5332bb6 Compare November 2, 2019 02:43

madebr force-pushed the librhash branch 2 times, most recently from 12ddebb to 7543db1 Compare November 2, 2019 19:31

madebr force-pushed the librhash branch 2 times, most recently from aad0afc to 2095881 Compare November 2, 2019 20:05

conan-center-bot removed the Failed label Nov 2, 2019

SSE4 previously approved these changes Nov 4, 2019

View reviewed changes

danimtb requested changes Nov 4, 2019

View reviewed changes

madebr dismissed SSE4’s stale review via 29781cc November 4, 2019 17:25

madebr force-pushed the librhash branch from 2095881 to 29781cc Compare November 4, 2019 17:25

danimtb requested a review from SSE4 November 7, 2019 16:09

uilianries reviewed Nov 12, 2019

View reviewed changes

madebr force-pushed the librhash branch from 29781cc to e28a288 Compare November 15, 2019 23:48

uilianries reviewed Nov 26, 2019

View reviewed changes

Comment thread recipes/librhash/all/conanfile.py Outdated

SSE4 previously approved these changes Nov 27, 2019

View reviewed changes

madebr dismissed SSE4’s stale review via df42b88 November 27, 2019 14:00

madebr force-pushed the librhash branch from e28a288 to df42b88 Compare November 27, 2019 14:00

madebr force-pushed the librhash branch 2 times, most recently from ae187c6 to 2593688 Compare November 27, 2019 14:28

danimtb requested review from SSE4 and uilianries December 20, 2019 09:53

uilianries reviewed Dec 20, 2019

View reviewed changes

Comment thread recipes/librhash/all/conanfile.py Outdated

madebr force-pushed the librhash branch from 2593688 to c558869 Compare January 11, 2020 01:01

conan-center-bot added the Failed label Jan 11, 2020

madebr force-pushed the librhash branch from c558869 to 6eeb1ef Compare January 25, 2020 10:32

Add librhash/1.3.9 recipe

afb731c

madebr force-pushed the librhash branch from 6eeb1ef to afb731c Compare January 25, 2020 11:29

conan-center-bot removed the Failed label Jan 25, 2020

SSE4 approved these changes Jan 28, 2020

View reviewed changes

danimtb requested a review from uilianries January 28, 2020 17:11

uilianries approved these changes Jan 28, 2020

View reviewed changes

danimtb approved these changes Jan 29, 2020

View reviewed changes

danimtb self-assigned this Jan 29, 2020

danimtb merged commit 94cdd67 into conan-io:master Jan 29, 2020

madebr deleted the librhash branch January 29, 2020 15:55

Uh oh!

Conversation

madebr commented Nov 2, 2019

Uh oh!

conan-center-bot commented Nov 2, 2019

Uh oh!

conan-center-bot commented Nov 2, 2019

Uh oh!

conan-center-bot commented Nov 2, 2019

Uh oh!

conan-center-bot commented Nov 2, 2019

Uh oh!

conan-center-bot commented Nov 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madebr Nov 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

conan-center-bot commented Nov 4, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

conan-center-bot commented Nov 16, 2019

Uh oh!

Uh oh!

conan-center-bot commented Nov 27, 2019

Uh oh!

conan-center-bot commented Nov 27, 2019

Uh oh!

conan-center-bot commented Nov 27, 2019

Uh oh!

conan-center-bot commented Dec 20, 2019

Uh oh!

Uh oh!

conan-center-bot commented Jan 11, 2020

Uh oh!

conan-center-bot commented Jan 15, 2020

Uh oh!

conan-center-bot commented Jan 25, 2020

Uh oh!

conan-center-bot commented Jan 25, 2020

Uh oh!

SSE4 commented Jan 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

madebr Nov 4, 2019 •

edited

Loading