common: clean up failed atomic writes - #38552
Merged
adeebshihadeh merged 2 commits intoAug 7, 2026
Merged
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
GavinnnK
force-pushed
the
agent/cleanup-atomic-write
branch
from
August 7, 2026 03:22
f919d2e to
c530648
Compare
Contributor
Author
|
CI note: the two failing jobs both stop in raylib startup because the external runner is missing libGLESv2.so.2. After rebasing onto current master, build release, build macOS, static analysis, and process replay (0 changed / 66 passed) all pass. No failure reaches the atomic_write change or its regression test. |
GavinnnK
marked this pull request as ready for review
August 7, 2026 03:44
GavinnnK
force-pushed
the
agent/cleanup-atomic-write
branch
from
August 7, 2026 19:42
c530648 to
58dd5da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atomic_writeusesdelete=False, so an exception from the writer left the partial temp file behind. Always remove it infinally; successful writes still use the sameos.replacepath.Adds a regression test for the error path.
Tested on Python 3.12.13. The focused regression, Ruff,
py_compile, andgit diff --checkpass.