ui: don't spam logs when NetworkManager is not available - #38504
Merged
adeebshihadeh merged 3 commits intoAug 7, 2026
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
|
This would be nice when working on WSL2 too! |
_get_adapter treats the reply body as a list of device paths without checking whether the reply is a D-Bus error. Without NetworkManager on the bus the body is an error string, so it iterates the string, throws on the first character, and the retry loop in _wait_for_wifi_device logs a traceback every second.
mpurnell1
force-pushed
the
fix-wifi-manager-nm-absent
branch
from
August 3, 2026 04:26
e6c57fc to
c6b3806
Compare
This reverts commit 5bb6a54.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This branch temporarily includes the CI fix from #38514 so the
Create UI Reportjob can run on fork PRsDescription
While working on #38502, I noticed the
Create UI Reportjob logs are full of repeated tracebacks fromwifi_manager.py(426 occurrences in the job linked below):_get_adaptertreats the reply body ofGetDevicesas a list of device paths without checking whether the reply is a D-Bus error. On hosts where D-Bus is up but NetworkManager is not on the bus (like the GitHub runners), the body is the error string"The name org.freedesktop.NetworkManager was not provided by any .service files", so the loop iterates the string character by character, throwsDBusAddress('T')on the first one, and the 1 second retry loop in_wait_for_wifi_devicelogs a traceback every second, forever. This affects any PC running the UI without NetworkManager, not just CI.The fix checks the reply type before using the body, matching how error replies are already handled elsewhere in the file.
Verification
Reproduced the error reply with plain jeepney against a bus without NetworkManager: the reply has
message_type == MessageType.error,body[0]is the error string, and iterating it yields'T'. The added guard catches exactly this case.Log with tracebacks (426 occurrences during Create UI Report step):
#38502 UI Report
Clean log on this branch:
#38504 UI Report