Eliminate audits.last query when filtering touch changes#774
Open
reid-rigo wants to merge 2 commits into
Open
Conversation
Cache the last-written audit's audited_changes on the instance so that the dedupe path in audit_touch can use it directly instead of issuing an extra SELECT for audits.last on every touch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
How is this supposed to work for multiple processes working simultaneously? Can a few tests be added to demonstrate the desired behavior when memoized changes are present/not present/outdated by another process? |
Contributor
Author
|
@akostadinov, this change is an optimization for the fix in #660 (added to PR description) In main the code assumes that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is an optimization for the fix introduced in #660
Cache the last audit changes on the instance to remove the
audits.lastquery when filtering changes inaudited_changes.