New configurable settings: encryption for audited_changes & filtering encrypted attrs

[sriddbs]

Closes #690

• Add new configurable vars:
  • encrypt_audited_changes default to false
  • filter_encrypted_attributes default to true

[sriddbs]

@danielmorrison please review and let me if the proposed config in the PR is good, also I wonder why some of the specs are failing 🤔

[danielmorrison]

Maybe another header here to show that these are separate features?

[sriddbs]

hmm, because we use encrypts, this config is also available only from Rails 7 ... so I grouped it under the same header

should I add a sub-header?

[danielmorrison]

Looking good to me. Test errors are something strange with coverage? Doesn't make sense offhand.

[sriddbs]

Looking good to me. Test errors are something strange with coverage? Doesn't make sense offhand.

I had the same errors with spec/audited/audit_spec, rspec clearly showed me the errors locally and I could fix it

for this it just runs fine

rspec spec/audited/auditor_spec.rb
Created database ':memory:'
............................................................................................................*.....*........................

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) Audited::Auditor without auditing should be thread safe using a #without_auditing block
     # No reason given
     # ./spec/audited/auditor_spec.rb:996

  2) Audited::Auditor with auditing should be thread safe using a #with_auditing block
     # No reason given
     # ./spec/audited/auditor_spec.rb:1077

[sriddbs]

@danielmorrison if this PR looks good, please merge?

[tvararu]

This doesn't seem to work as expected, it appears that this is evaluated before the Audited.encrypt_audited_changes = true in the initializer runs so it evaluates to false initially and is never re-evaluated. The encrypts call below never runs as a result.

[srg-bnd]

How are you doing with PR?

[srg-bnd]

Is it necessary to take into account the deterministic encryption?

[jesseduffield]

Just stumbled upon this PR. I'd love to have this functionality. Is anything blocking this currently @danielmorrison ?