fix: bump fast-xml-parser to 5.3.5 (CVE-2026-25896) - #3468
Open
anupamme wants to merge 1 commit into
Open
Conversation
fast-xml-parser 5.3.4 is affected by CVE-2026-25896; 5.3.5 is the minimal patched version. The library enters as a transitive devDep via webdriverio → @wdio/utils → edgedriver. A root-level Yarn resolution pins it to 5.3.5 across all transitive consumers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR mitigates CVE-2026-25896 by pinning the transitive devDependency fast-xml-parser to 5.3.5 at the workspace root, ensuring the vulnerable 5.3.4 is no longer selected in the dependency graph used by the e2e tooling chain.
Changes:
- Add a root-level Yarn
resolutionsoverride to forcefast-xml-parserto5.3.5. - Update
yarn.lockto reflectfast-xml-parser@5.3.5and its updated transitive dependencies (strnum→2.4.2, addinganynum).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds a resolutions pin for fast-xml-parser to 5.3.5. |
| yarn.lock | Updates the resolved dependency entries/checksums for fast-xml-parser and its transitive dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fast-xml-parserto5.3.5via a root-level Yarnresolutionsentry, replacing the previously locked5.3.4which is affected by CVE-2026-25896.package.json(one-line addition toresolutions) andyarn.lock(updated checksum + version lines) are changed.Background
fast-xml-parserenters the project as a transitive devDependency only, via:The library is never imported by the project's own source or test code; it is used internally by
edgedriverto parse XML responses from the Edge WebDriver service during e2e tests. No runtime or production surface is affected.Why no regression test
There is no direct call-site for
fast-xml-parserin this codebase to test against. The fix is fully verified by the resolved version inyarn.lock(fast-xml-parser@npm:5.3.5) and by runningyarn why fast-xml-parserpost-install.Why no changeset
This change only affects a transitive devDependency. No published package's API or runtime behavior is altered.
Closes / relates to
Replaces the now-closed #3464, which addressed the same CVE but was based on a stale branch that carried unrelated commits. This PR is based directly on current
masterwith only the minimal change.🤖 Generated with Claude Code