chore(core): promote alg.rightAnglePath and rightAngle's useModelGeometry to public API - #3465
Draft
kumilingus wants to merge 1 commit into
Draft
chore(core): promote alg.rightAnglePath and rightAngle's useModelGeometry to public API#3465kumilingus wants to merge 1 commit into
kumilingus wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changesets promoting API introduced (as
@internal) by #3457 to the public API in the next minor release:alg.rightAnglePath()- therightAnglerouter's path-finding algorithm as a public utilityuseModelGeometryoption on therightAnglerouterBefore merging
@internaltag (and the "not part of the public API yet" wording) fromrightAnglePath/RightAnglePathOptionsinpackages/joint-core/types/alg.d.ts@internaltag fromuseModelGeometryinpackages/joint-core/types/routers.d.tstargetInSourceBBoxoption first - it is flagged in the code as a temporaryrightAnglerouter internal to be removed (deduced inside the algorithm) before the API is frozenMerge as part of the next minor release train - the changesets bump
@joint/coreaccordingly.🤖 Generated with Claude Code