Draft: Small stepgrid change - #733
Open
kbarnhart wants to merge 1 commit into
Open
Conversation
Member
|
This is probably true for any field that is momentum related I suppose. Most of the other fields, unless they somehow have velocity issues, would not necessarily want to zero it out either. In the multilayer code we do the following: forall(i=1:mitot, j=1:mjtot, k=1:num_layers,
& q(3*(k-1)+1,i,j) / rho(k) < dry_tolerance(k))
q(3*(k-1)+1,i,j) = max(q(3*(k-1)+1,i,j), 0.d0)
q(3*(k-1)+2,i,j) = 0.d0
q(3*(k-1)+3,i,j) = 0.d0
end forallGiven the momentum equations are interspersed with the other fields, this also required another In any case, modulo the bouss code, I think being explicit about this is probably fine. The alternative would be to call something that would do only this custom bit. I suppose this might be a recurring task that may be easier to implement that way, but that may be too complex a solution for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another change based on D-Claw development: In D-Claw we have one variable in q that should not be set to zero when q(1)<drytol.
This suggestion is intended to retain geoclaw functionality, but not require a D-Claw specific routine that differs only by this line.
@rjleveque @mandli @dlgeorge