Skip to content

Switch to extension owner when modifying job_run_details. #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChangAo Chen (ChenChangAo) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch to extension owner when modifying job_run_details. #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/job_metadata.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,6 +1081,8 @@ InsertJobRunDetail(int64 runId, int64 *jobId, char *database, char *username, ch
Oid argTypes[6];
Datum argValues[6];
MemoryContext originalContext = CurrentMemoryContext;
Oid savedUserId = InvalidOid;
int savedSecurityContext = 0;

SetCurrentStatementStartTimestamp();
StartTransactionCommand();
Expand All @@ -1096,6 +1098,9 @@ InsertJobRunDetail(int64 runId, int64 *jobId, char *database, char *username, ch

initStringInfo(&querybuf);

GetUserIdAndSecContext(&savedUserId, &savedSecurityContext);
SetUserIdAndSecContext(CronExtensionOwner(), SECURITY_LOCAL_USERID_CHANGE);

/* Open SPI context. */
if (SPI_connect() != SPI_OK_CONNECT)
elog(ERROR, "SPI_connect failed");
Expand Down Expand Up @@ -1136,6 +1141,7 @@ InsertJobRunDetail(int64 runId, int64 *jobId, char *database, char *username, ch
pfree(querybuf.data);

SPI_finish();
SetUserIdAndSecContext(savedUserId, savedSecurityContext);
PopActiveSnapshot();
CommitTransactionCommand();
MemoryContextSwitchTo(originalContext);
Expand All @@ -1150,6 +1156,8 @@ UpdateJobRunDetail(int64 runId, int32 *job_pid, char *status, char *return_messa
Datum argValues[6];
int i;
MemoryContext originalContext = CurrentMemoryContext;
Oid savedUserId = InvalidOid;
int savedSecurityContext = 0;

SetCurrentStatementStartTimestamp();
StartTransactionCommand();
Expand All @@ -1166,6 +1174,9 @@ UpdateJobRunDetail(int64 runId, int32 *job_pid, char *status, char *return_messa
initStringInfo(&querybuf);
i = 0;

GetUserIdAndSecContext(&savedUserId, &savedSecurityContext);
SetUserIdAndSecContext(CronExtensionOwner(), SECURITY_LOCAL_USERID_CHANGE);

/* Open SPI context. */
if (SPI_connect() != SPI_OK_CONNECT)
elog(ERROR, "SPI_connect failed");
Expand Down Expand Up @@ -1237,6 +1248,7 @@ UpdateJobRunDetail(int64 runId, int32 *job_pid, char *status, char *return_messa
pfree(querybuf.data);

SPI_finish();
SetUserIdAndSecContext(savedUserId, savedSecurityContext);
PopActiveSnapshot();
CommitTransactionCommand();
MemoryContextSwitchTo(originalContext);
Expand Down Expand Up @@ -1421,6 +1433,8 @@ MarkPendingRunsAsFailed(void)
{
StringInfoData querybuf;
MemoryContext originalContext = CurrentMemoryContext;
Oid savedUserId = InvalidOid;
int savedSecurityContext = 0;

SetCurrentStatementStartTimestamp();
StartTransactionCommand();
Expand All @@ -1436,6 +1450,9 @@ MarkPendingRunsAsFailed(void)

initStringInfo(&querybuf);

GetUserIdAndSecContext(&savedUserId, &savedSecurityContext);
SetUserIdAndSecContext(CronExtensionOwner(), SECURITY_LOCAL_USERID_CHANGE);

/* Open SPI context. */
if (SPI_connect() != SPI_OK_CONNECT)
elog(ERROR, "SPI_connect failed");
Expand All @@ -1452,6 +1469,7 @@ MarkPendingRunsAsFailed(void)
pfree(querybuf.data);

SPI_finish();
SetUserIdAndSecContext(savedUserId, savedSecurityContext);
PopActiveSnapshot();
CommitTransactionCommand();
MemoryContextSwitchTo(originalContext);
Expand Down