Extrema, Usage Profile: Show the analyzed time range readably on the chart - #168
Merged
Conversation
The x axis shows notable PEs, so nothing on the chart said what time interval the analysis covered. Flank the chart title with the loaded time range (left) and the processor selection (right), using the title-annotation hook Graph already has; both trim to fit the window. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The title expanded the full PE list (Util.listToString), so at hundreds of PEs it grew wider than the canvas and everything that identifies the chart scrolled out of sight, including the time range on the second line. Use the strided selection summary instead, and print the time range with time units rather than bare millisecond floats. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Chart headers borrowed the range dialog's full-precision time format (as many decimals as the number has digits). New U.humanReadableRange prints a time range with at most three decimals, adding digits only when the range is so narrow that the endpoints would print alike. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lvkale
requested review from
ericjbohm,
matthiasdiener and
ritvikrao
as code owners
August 23, 2026 03:42
ritvikrao
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Kale's wishlist, verified by him in the GUI on the 896-PE frontier trace.
Extrema: the x axis shows notable PEs, so nothing on the chart said what time interval the analysis covered. The chart title is now flanked by the analyzed time range (left) and the processor selection (right), using the title-annotation hook
Graphgained in #163; both trim to fit a narrow window. Works for the range-dialog path and the online-outlier path.Usage Profile already printed the time range as the second title line, but the first line expanded the full PE list (
Util.listToString), so at hundreds of PEs it grew wider than the canvas and everything identifying the chart was lost. It now uses the strided selection summary ("896 PEs (all)", "384 of 1920 PEs: 0-1915:5").Both headers print times with the new
U.humanReadableRange: at most three decimal places, adding digits only when the range is so narrow the endpoints would otherwise print alike (1.2345s - 1.2346s). Previously they inherited the range dialog's full-precision format (as many decimals as the number has digits).🤖 Generated with Claude Code