enh(dependencies): package missing lua dependencies#363
Conversation
sdepassio
force-pushed
the
CTOR-575-package-missing-dependencies
branch
from
ac2157c to
bd4fe3f
Compare
sdepassio
force-pushed
the
CTOR-575-package-missing-dependencies
branch
from
63cfb30 to
b93aed6
Compare
sdepassio
force-pushed
the
CTOR-575-package-missing-dependencies
branch
from
0540ab4 to
cf9480a
Compare
sdepassio
requested review from
kduret,
mushroomempires,
omercier,
tanguyvda and
tuntoja
and removed request for
a team
| - name: Publish DEB packages | ||
| uses: ./.github/actions/deb-delivery | ||
| with: | ||
| module_name: lua-tz |
There was a problem hiding this comment.
with L176, since module_name gives the package its name, this results in packages having a different name in deb and rpm, is it a constraint ?
| pull_request: | ||
| paths: | ||
| - '.github/workflows/lua-base64.yml' | ||
| - '../../dependencies/lua-base64/**' |
There was a problem hiding this comment.
| - '../../dependencies/lua-base64/**' | |
| - 'dependencies/lua-base64/**' |
| - master | ||
| paths: | ||
| - '.github/workflows/lua-base64.yml' | ||
| - '../../dependencies/lua-base64/**' |
There was a problem hiding this comment.
| - '../../dependencies/lua-base64/**' | |
| - 'dependencies/lua-base64/**' |
| distrib: ${{ matrix.distrib }} | ||
| package_extension: ${{ matrix.package_extension }} | ||
| arch: amd64 | ||
| version: "0.11.1-1" |
There was a problem hiding this comment.
| version: "0.11.1-1" | |
| version: "0.11.1" |
version should be purely semver based with nfpm
| version: "1.5" | ||
| release: "3" |
There was a problem hiding this comment.
given the reference appears to be semver v1.5.3, package version should also be 1.5.3
| with: | ||
| repository: "iskolbin/lbase64" | ||
| path: "base64-src" | ||
| ref: "v1.5.3" |
There was a problem hiding this comment.
pin version: this should be the commit sha pointed by the tag, with ref "version" as a comment (similar to what is done to pin actions)
| with: | ||
| repository: "zhaozg/lua-openssl" | ||
| path: "lua-openssl-src" | ||
| ref: "0.11.1-1" |
There was a problem hiding this comment.
pin version: this should be the commit sha pointed by the tag, with ref "version" as a comment (similar to what is done to pin actions)
2 participants
Description
Some Lua libraries needs to be packaged to install and run centreon-stream-connectors.
Fixes CTOR-575
Type of change
Target serie
Checklist
Community contributors & Centreon team