Skip to content

docs: document fill()'s caller-supplied fillDeadline parameter #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dev-aly3n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: document fill()'s caller-supplied fillDeadline parameter #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/output/OutputSettlerBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ abstract contract OutputSettlerBase is IAttester, BaseInputOracle {
* and scenarios where multiple parties might attempt to fill the same output.
* @param orderId The unique identifier of the order.
* @param output The `MandateOutput` struct to fill.
* @param fillDeadline MUST equal the signed order's `fillDeadline`. This is a caller-supplied guard only. It is
* not validated against the order, which this contract never sees. A larger value lets a late fill SUCCEED, and
* `finalise` will then permanently reject the claim with `FilledTooLate`.
* @param fillerData The solver data containing the proposed solver.
* @return fillRecordHash The hash of the fill record.
*/
Expand Down Expand Up @@ -263,6 +266,9 @@ abstract contract OutputSettlerBase is IAttester, BaseInputOracle {
* and ensures consistent solver attribution across all outputs in a multi-output order.
* @param orderId The unique identifier of the order.
* @param outputs Array of `MandateOutput` structs to fill
* @param fillDeadline MUST equal the signed order's `fillDeadline`. This is a caller-supplied guard only. It is
* not validated against the order, which this contract never sees. A larger value lets a late fill SUCCEED, and
* `finalise` will then permanently reject the claim with `FilledTooLate`.
* @param fillerData The solver data containing the proposed solver.
*/
function fillOrderOutputs(
Expand Down