test: remove sqlite skips for queue-worker tracing (merge after cds spawn fix) - #467
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request:
Remove SQLite Skip Guards for Queue-Worker Tracing TestsTest🧪 Removes the temporary SQLite skip guards from 5 queue-worker tracing test suites that were added in #465 as a workaround for a Changes
Jira Issues (ONLY add this section if JIRA issues are available)N/A Related PRs
PR Bot InformationVersion:
|
There was a problem hiding this comment.
- Could not get issue
cap-js/telemetry#6594. Status: 404 - UnknownObjectException
The changes are straightforward — they remove temporary sqlite skip guards from five test files. Looking at the diff carefully:
-
In
tracing-messaging-inboxed.test.jsandtracing-messaging-outboxed-and-inboxed.test.js, theconst cds = require('@sap/cds')line is being removed along with the sqlite guard. However,cdsis not used anywhere else in those files — so the removal is clean. -
In
tracing-outboxed-batch.test.jsandtracing-scheduled.test.js,cdsis still used in the file (forcds.test(...),cds.version,cds.connect.to, etc.), so the removal of the guard is fine and does not leave a dangling require. -
In
tracing-messaging-persistent-outbox.test.js, same as the messaging files —cdsis not directly used in the file body outside what was removed.
The PR description is clear that this is intentionally gated on an upstream CDS fix and the checklist items are unresolved. There are no logic errors, bugs, or maintainability issues introduced by the diff itself — all the removals are consistent and correct.
This is a clean, intentional removal of temporary workaround guards. The diff is correct and all five files are consistent — no issues to flag. The open checklist items in the PR description (#465 merged and @sap/cds bumped) are the only remaining gates before merge, which are appropriately tracked in the PR description itself.
PR Bot Information
Version: 1.29.18
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened - Correlation ID:
9e2d0e20-919a-11f1-97de-effae0c5a313 - File Content Strategy: Full file content
60e48a9 to
b281c8f
Compare
9595503 to
31e0441
Compare
b281c8f to
9b88203
Compare
81c9cd9 to
5eb33aa
Compare
89d1e87 to
29710d5
Compare
5eb33aa to
5fe19e4
Compare
29710d5 to
3983e27
Compare
5fe19e4 to
179982c
Compare
3983e27 to
74d924a
Compare
179982c to
91c38f7
Compare
Removes the sqlite skip guards added while the cds queue-spawn fix was pending. With cds routing the sqlite queue worker through cds.spawn (cap/cds branch test/queue-spawn-sqlite-extended-tenant: removes the setTimeout bypass and fixes the underlying deadlock by wrapping ExtendedModels.model4() in cds.tx()), the 'cds.spawn - run task' root span and its child tx spans now appear on sqlite too. Merge only after that cds fix is released and the @sap/cds dependency is bumped.
91c38f7 to
d1812a1
Compare
Depends on
@sap/cdsbumped: cap/cdstest/queue-spawn-sqlite-extended-tenant— removes the sqlitesetTimeoutbypass inlibx/queue/processing.js(_begin = cds.spawn.bind(cds)) and fixes the actual single-writer deadlock by wrappingExtendedModels.model4()incds.tx()insidelib/req/spawn.js.What
Removes the 5 sqlite skip guards added in #465. Once cds routes the sqlite queue worker through
cds.spawn, thecds.spawn - run taskroot span and its child tx spans appear on sqlite, so these suites verify the full path on sqlite (not just HANA):tracing-scheduled.test.jstracing-outboxed-batch.test.jstracing-messaging-inboxed.test.jstracing-messaging-outboxed-and-inboxed.test.jstracing-messaging-persistent-outbox.test.jsVerified
Locally against a workspace-linked
@sap/cdsattest/queue-spawn-sqlite-extended-tenant: all 5 suites pass on sqlite.Do not merge until
@sap/cdsdependency bumped in a preceding commit