Skip to content

Fix SQL injection in hasDatabase() by quoting database name in adapters #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterOdin merged 5 commits into from
Jul 3, 2026
+20 −5
Merged

Fix SQL injection in hasDatabase() by quoting database name in adapters #2418

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d97fb44
Add missing escaping to adapters
markstory Jun 29, 2026
15a94eb
Refactor SQL query in hasDatabase method
MasterOdin Jun 30, 2026
d63a1f9
Fix SQL string quotes in hasDatabase method
MasterOdin Jun 30, 2026
a58d397
Fix string quotes in SQL query for SQL Server
MasterOdin Jun 30, 2026
2cc391c
add tests
MasterOdin Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Phinx/Db/Adapter/MysqlAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1419,8 +1419,8 @@ public function hasDatabase(string $name): bool
{
$rows = $this->fetchAll(
sprintf(
'SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = \'%s\'',
$name,
'SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = %s',
$this->getConnection()->quote($name),
),
);

Expand Down
1 change: 1 addition & 0 deletions src/Phinx/Db/Adapter/PostgresAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,7 @@ public function createDatabase(string $name, array $options = []): void
*/
public function hasDatabase(string $name): bool
{
$name = $this->getConnection()->quote($name);
$sql = sprintf("SELECT count(*) FROM pg_database WHERE datname = '%s'", $name);
$result = $this->fetchRow($sql);

Expand Down
4 changes: 2 additions & 2 deletions src/Phinx/Db/Adapter/SqlServerAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,8 +1198,8 @@ public function hasDatabase(string $name): bool
/** @var array<string, mixed> $result */
$result = $this->fetchRow(
sprintf(
"SELECT count(*) as [count] FROM master.dbo.sysdatabases WHERE [name] = '%s'",
$name,
"SELECT count(*) as [count] FROM master.dbo.sysdatabases WHERE [name] = %s",
$this->getConnection()->quote($name),
),
);

Expand Down
Loading