-
Notifications
You must be signed in to change notification settings - Fork 0
LAB-737: Stage 3 — live integration on dev.cachekit (interop + stampede + secure cache) #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
caeb04e
LAB-737: Stage 3 — live integration on dev.cachekit (interop + stampe…
27Bslash6 1bfee17
LAB-737: apply expert-panel findings
27Bslash6 427d856
LAB-737: address Kody review round
27Bslash6 2ca7d6f
LAB-737: kill the master-key-shaped literal in derive_keys entirely
27Bslash6 ab36e3d
LAB-737: address CodeRabbit round
27Bslash6 393dfeb
LAB-737: fix the two defects the finally-cleanup introduced (Kody rou…
27Bslash6 dcb6da0
LAB-737: apply second expert-panel findings (human-requested pre-merg…
27Bslash6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,6 @@ __pycache__/ | |
| Cargo.lock | ||
| .pytest_cache/ | ||
| .ruff_cache/ | ||
| .op.env | ||
|
|
||
| .op.apikey.env | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /** | ||
| * Build-time stub for `@cachekit-io/cachekit-core-ts` (wrangler [alias]). | ||
| * | ||
| * The real package is a NAPI native module (.node binaries) that can never | ||
| * run on Cloudflare Workers — bundling it is what breaks `wrangler deploy` | ||
| * on @cachekit-io/cachekit 0.1.3 (0.1.4 replaces it with a WASM core, but | ||
| * that bump is blocked upstream: LAB-780). The SDK only imports `ByteStorage` | ||
| * from it statically, and only the compression path of the Cache class ever | ||
| * constructs one. The edge never uses that path: it reads raw bytes via | ||
| * `backend.get()` and decodes interop/v1 (plain MessagePack, no ByteStorage | ||
| * envelope by contract). So the honest stub is one that throws on use — | ||
| * dead weight is aliased away, and any future code path that would silently | ||
| * depend on the native module fails loudly instead. | ||
| */ | ||
| export class ByteStorage { | ||
| constructor() { | ||
| throw new Error( | ||
| 'ByteStorage is not available on Cloudflare Workers: ' + | ||
| '@cachekit-io/cachekit-core-ts is a native NAPI module (stubbed at build time). ' + | ||
| 'The edge reads interop/v1 payloads, which never use the ByteStorage envelope.', | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.