Support persistent split with s3 provider - #1122
Open
SmaGMan wants to merge 2 commits into
Open
Conversation
SmaGMan
force-pushed
the
feature/s3-split-persistent
branch
from
August 20, 2026 09:18
6ef715d to
78984d4
Compare
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1122Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
+ Coverage 60.43% 60.45% +0.02%
==========================================
Files 487 487
Lines 85229 85271 +42
Branches 85229 85271 +42
==========================================
+ Hits 51504 51547 +43
+ Misses 31202 31201 -1
Partials 2523 2523 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SmaGMan
force-pushed
the
feature/s3-split-persistent
branch
from
August 20, 2026 09:52
78984d4 to
090edba
Compare
SmaGMan
marked this pull request as ready for review
August 20, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
[None]
BLOCKCHAIN CONFIGURATION MODEL CHANGES
[None]
COMPATIBILITY
Fully compatible
persistent_state_split_depththe uploader will store a single-file state without metadata.PersistentStateMetaschema and validated before it is used.SPECIAL DEPLOYMENT ACTIONS
[Required]
Deploy the updated Tycho nodes before deploying the updated uploader. This ensures that every S3 persistent-state reader can process the metadata and declared state files published by the uploader.
On the testnet:
.core_storage.persistent_state_split_depth = 3.core_storage.persistent_state_split_depth = 3PERFORMANCE IMPACT
[No impact expected]
TESTS
Unit Tests
[Covered by:]
persistent_state_meta_bytes_roundtrippersistent_state_discovery_handles_legacy_and_split_bundlespersistent_state_manifest_rejects_incomplete_and_invalid_bundlespersistent_state_download_selects_main_or_declared_parts3_rpc_provider_advertises_split_info_and_reads_declared_parts3_starter_client_returns_split_found_state_and_downloads_main_and_partsplit_persistent_shard_state_import_from_dumpNetwork Tests
[No coverage]
Manual Tests
Manual tests used:
.blockchain_rpc_service.serve_persistent_states = falseand.core_storage.persistent_state_split_depth = 2.core_storage.persistent_state_split_depth = 2mcto check that persistent state bundle was successfully uploaded to s3