feat(governance): proposal votes fixtures for counted flag and CC cc_hot ids - #113
Open
slowbackspace wants to merge 2 commits into
Open
feat(governance): proposal votes fixtures for counted flag and CC cc_hot ids#113slowbackspace wants to merge 2 commits into
slowbackspace wants to merge 2 commits into
Conversation
… CC cc_hot ids Mainnet: add the new counted field to every vote entry of the existing proposal votes fixture (9 of 100 votes on page 1 are uncounted - superseded re-votes or votes of DReps deregistered while the proposal was live), and add a fixture for a committee-voted proposal (b2a591ac...#0) covering constitutional committee voters returned as CIP-129 cc_hot ids instead of raw hex. Expected values generated from mainnet cardano-db-sync with the queries shipping in blockfrost-backend-ryo#351 and #352 (needs both deployed, plus the @blockfrost/openapi release with blockfrost/openapi#468). Ref blockfrost/openapi#465 blockfrost/openapi#466
…counted and cc_hot Preprod: add counted to all 6 entries (the pool1yzwxe... vote in tx 45f18dec is superseded by its later re-vote, so counted: false) and convert the constitutional committee voter from raw hex to its CIP-129 cc_hot id (script credential). Preview: add counted to all 11 entries; 6 DRep votes are uncounted (deregistered while the proposal was live, or superseded). Expected values generated from preprod/preview cardano-db-sync with the queries shipping in blockfrost-backend-ryo#351 and #352; voter ids cross-checked against the CIP-129 values already present in the fixtures. Ref blockfrost/openapi#465 blockfrost/openapi#466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
/governance/proposals/{tx_hash}/{cert_index}/votesfixtures for the changes in blockfrost/blockfrost-backend-ryo#351 (constitutional committee voters returned as CIP-129cc_hot1...ids instead of ambiguous raw hex — blockfrost/openapi#465) and blockfrost/blockfrost-backend-ryo#352 (newcountedboolean per vote — blockfrost/openapi#466).Changes
countedadded to all 100 entries of the existing fixture (9 uncounted: superseded re-votes or DReps deregistered while the proposal was live); new fixture for the committee-voted proposalb2a591ac...#0(7 CC votes, allcc_hot1...) as a regression case for the CIP-129 conversioncountedadded (thepool1yzwxe...vote in tx45f18decis superseded by its later re-vote →false); CC voter converted from raw hexe3a4c41d...tocc_hot1q036f3qavavj5xudslrzuhzaw0m73kurv9ceg4qj6yl5p7qf4a3gzcountedadded to all 11 entries (6 uncounted)Verification
Expected values were generated straight from each network's cardano-db-sync using the exact queries shipping in the backend PRs. All pre-existing entry data (order, voters, votes) reproduced identically; the DRep CIP-129 conversions were additionally cross-checked against the values already present in the fixtures.
Merge order
countednor cc_hot ids and these fixtures will fail.