Add Artillery Lab with ravine send-off - #5019
Closed
RL-Charles wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Charles Mowbray <charles@archil.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
This provides a fast interactive agent-versus-agent game lab and makes the destructive loser action explicit, functional, and visually clear. The cinematic runs only after deletion succeeds, so it cannot imply an agent was removed when the operation failed.
Validation
cd desktop && pnpm build:e2enode --import ./test-loader.mjs --experimental-strip-types --test src/features/games/artillery/*.test.mjs— 17 passedpnpm exec playwright test tests/e2e/game-lab.spec.ts --project=smoke— 5 passed